Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this is that you can 'overlay' raw & proc data and still be able to access either:
I'm not sure about this yet - it makes bits of the code rather more complex, and it might not be used that often.
The aim is that you can have a combined view of the data - e.g. to do
.select(..., require_all=True)
- and specifically access e.g. AGIPD proc data, telling it that you want proc data so it fails if that's missing rather than quietly switching to raw (#292). We could even makedata=('raw', 'proc')
the default without changing things that already work (mostly).@philsmt this would be an alternative to your #298. In this PR, the first named origin containing a source 'wins', as opposed to the last in your PR.