-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump vulnz-nvd-mirror version to 7.0.2 #65
feat: bump vulnz-nvd-mirror version to 7.0.2 #65
Conversation
remove predefined JAVA_OPT memory allocation setting (ref: jeremylong/open-vulnerability-cli#224)
Thank you. Please revert the Java option removal, other than that it looks good already |
Since i want to upgrade vulnz, i would love to push this forward. Could you remove the changes i asked for so we can merge this one? Thanks! |
Hello @EugenMayer
Could you explain a bit please? This option is not needed, Java now understands cgroups natively |
Fair point! so you refer to using https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-requests-and-limits-of-pod-and-container via the chart https://truecharts.org/common/resources/#resourceslimitsmemory to limit the memory of the java process. Beside this is not the same as defining the mean heap, i think you make a good point here. I would still suggest adding limits to this charts by default (due to the nature of the actual application itself). Are you in on just adding resource limits in the same ballpark (that could be changed by anyone later one via the values)? |
Do I understand right you are suggest adding default memory limit to |
Yes, this was the suggestion |
Thank you! |
remove predefined JAVA_OPT memory allocation setting (ref: jeremylong/open-vulnerability-cli#224)