Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump vulnz-nvd-mirror version to 7.0.2 #65

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

okgolove
Copy link
Contributor

@okgolove okgolove commented Dec 2, 2024

remove predefined JAVA_OPT memory allocation setting (ref: jeremylong/open-vulnerability-cli#224)

remove predefined JAVA_OPT memory allocation setting (ref: jeremylong/open-vulnerability-cli#224)
@EugenMayer
Copy link
Owner

Thank you. Please revert the Java option removal, other than that it looks good already

@EugenMayer
Copy link
Owner

Since i want to upgrade vulnz, i would love to push this forward. Could you remove the changes i asked for so we can merge this one? Thanks!

@okgolove
Copy link
Contributor Author

okgolove commented Dec 4, 2024

Hello @EugenMayer

Please revert the Java option removal

Could you explain a bit please? This option is not needed, Java now understands cgroups natively

@EugenMayer
Copy link
Owner

Fair point! so you refer to using https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-requests-and-limits-of-pod-and-container via the chart https://truecharts.org/common/resources/#resourceslimitsmemory to limit the memory of the java process.

Beside this is not the same as defining the mean heap, i think you make a good point here.

I would still suggest adding limits to this charts by default (due to the nature of the actual application itself). Are you in on just adding resource limits in the same ballpark (that could be changed by anyone later one via the values)?

@okgolove
Copy link
Contributor Author

okgolove commented Dec 6, 2024

Do I understand right you are suggest adding default memory limit to resources block, don't you?

@EugenMayer
Copy link
Owner

Yes, this was the suggestion

@EugenMayer
Copy link
Owner

Thank you!

@EugenMayer EugenMayer merged commit 75048be into EugenMayer:main Dec 7, 2024
@okgolove okgolove deleted the feature/bump-vulnz-nvd-mirror branch December 8, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants