Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil excludes error (rsync strategy) #821

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix nil excludes error (rsync strategy) #821

merged 1 commit into from
Sep 13, 2022

Conversation

yosephsa
Copy link
Contributor

Fix rsync nil error when sync_excludes is undefined.

@yosephsa yosephsa changed the title Fix nil excludes error rsync Fix nil excludes error rsync strategy Sep 13, 2022
@yosephsa yosephsa changed the title Fix nil excludes error rsync strategy Fix nil excludes error (rsync strategy) Sep 13, 2022
@vokshirg
Copy link

not only one strategy affected 190d93d

unison also get:

bad pattern:  .docker-sync/daemon.log
A pattern must be introduced by one of the following keywords:
Name, Path, BelowPath or Regex.

@EugenMayer
Copy link
Owner

EugenMayer commented Sep 13, 2022 •
edited
Loading

@yoseph1998 is this a dupe of #820 ? I would say yes, but partially, the other does more

@EugenMayer
Copy link
Owner

Oh, one is for rsync, one is for unison .. and we will probably need one for native_osx too?

@EugenMayer
Copy link
Owner

Thank you for the contribution!

@EugenMayer EugenMayer merged commit 29d8a85 into EugenMayer:main Sep 13, 2022
@EugenMayer EugenMayer mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yosephsa @vokshirg @EugenMayer @yalabdulwahab-cspire