Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/drop x #2

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/drop x #2

wants to merge 9 commits into from

Conversation

Bundologus
Copy link

@Bundologus Bundologus commented Oct 27, 2020 •
edited
Loading

Changed:

Added:

  • dice notation validation with regexp
  • functionality to handle drop-lowest and drop-highest roll variants
  • test cases to test new functionality (except for drop-highest)
  • a script that runs all test cases (phpunit batch run kept throwing errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bundologus