fix: emit empty scalars as "" instead of "~" #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-my-profile
force-pushed
the
fix-empty-scalar
branch
from
93223f9
to
b02bb60
Compare
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Sep 8, 2024
Previously attempting to deserialize the value of `foo` in:
foo:
failed when a mapping, sequence or unit was expected.
Note that this fix depends on a related bug fix in yaml-rust2:
Ethiraric/yaml-rust2#37. So that:
foo: null
or
foo: ~
can still result in errors when a mapping/sequence/unit is expected.
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Sep 8, 2024
Previously attempting to deserialize the value of `foo` in:
foo:
failed when a mapping, sequence or unit was expected.
Note that this fix depends on a related bug fix in yaml-rust2:
Ethiraric/yaml-rust2#37. So that:
foo: null
or
foo: ~
can still result in errors when a mapping/sequence/unit is expected.
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Sep 8, 2024
Previously attempting to deserialize the value of `foo` in:
foo:
failed when a mapping, sequence or unit was expected.
Note that this fix depends on a related bug fix in yaml-rust2:
Ethiraric/yaml-rust2#37. So that:
foo: null
or
foo: ~
can still result in errors when a mapping/sequence/unit is expected.
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Sep 8, 2024
Previously attempting to deserialize the value of `foo` in:
foo:
failed when a mapping, sequence or unit was expected.
Note that this fix depends on a related bug fix in yaml-rust2:
Ethiraric/yaml-rust2#37. So that:
foo: null
or
foo: ~
can still result in errors when a mapping/sequence/unit is expected.
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Sep 8, 2024
Previously attempting to deserialize the value of `foo` in:
foo:
failed when a mapping, sequence or unit was expected.
Note that this fix depends on a related bug fix in yaml-rust2:
Ethiraric/yaml-rust2#37. So that:
foo: null
or
foo: ~
can still result in errors when a mapping/sequence/unit is expected.
|
Thank you for your contribution! ❤️ |
|
You're welcome! Could you publish a new version so that I can contribute the related fixes to marked-yaml? Sidenote: It might be worth adding a note about the missing serde support to the README:
|
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Oct 3, 2024
I fixed the parsing of empty scalars in rust-yaml, see Ethiraric/yaml-rust2#37.
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Oct 3, 2024
I fixed the parsing of empty scalars in rust-yaml, see Ethiraric/yaml-rust2#37.
not-my-profile
added a commit
to not-my-profile/marked-data
that referenced
this pull request
Oct 3, 2024
I fixed the parsing of empty scalars in rust-yaml, see Ethiraric/yaml-rust2#37.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36.