Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allowance of passing alternate transaction nonce value on contract #147

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fix allowance of passing alternate transaction nonce value on contract #147

merged 1 commit into from
Mar 4, 2021
+1 −1

Conversation

ccozkan
Copy link
Contributor

@ccozkan ccozkan commented Jan 15, 2021

Fixes ability of changing nonce which is introduced by #58, and later it seems to be removed by #112

@kurotaky kurotaky merged commit bd9a933 into EthWorks:master Mar 4, 2021
@kurotaky
Copy link
Collaborator

kurotaky commented Mar 4, 2021

@ccozkan Thanks!

@longhoangwkm
Copy link
Contributor

Thanks for fixing it, It's my fault, I should fix my issue by creating new instances instead of stopping the nonce change

@ccozkan
Copy link
Contributor Author

ccozkan commented Mar 5, 2021

No problem! It was fun 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurotaky kurotaky kurotaky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccozkan @kurotaky @longhoangwkm