Tasks examples update: added new tasks examples in test-resources #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "label": "Test compile problemMatcher", | ||
| "type": "shell", | ||
| "command": "tsc ${file}", |
There was a problem hiding this comment.
I don't believe this task actually works as intended in the test-resources workspace, there are no typescript files to run tsc on.
Comment on lines
85
to
89
| "presentation": { | ||
| "reveal": "always", | ||
| "panel": "new", | ||
| "clear": true | ||
| } |
There was a problem hiding this comment.
Is there a reason we want to repeat the same presentation options for:
test presentationtest compound tasktest input variables
All three of them use:
"presentation": {
"reveal": "always",
"panel": "new",
"clear": true
}| "id": "taskName", | ||
| "description": "enter the task name", | ||
| "type": "promptString", | ||
| "default": "Create a new class" |
There was a problem hiding this comment.
Why class here? It can be as simple as Name or Task Name.
Suggested change
| "default": "Create a new class" | |
| "default": "Name" |
There was a problem hiding this comment.
Hi @vince-fugnitto, many thanks for your comments. I have updated my code accordingly.
added new tasks examples in test-resources Added new tasks examples to include problemMatchers, compound tasks, presentation options and variables substitution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Add more options of tasks examples in test-resources to tests.
Closes eclipse-theia#6348
How to test
Review checklist
Reminder for reviewers