feat(): add create form error validation for site and project entities (

#1691)
Esri · Nov 4, 2024 · 43dab51 · 43dab51
1 parent eebf07f
commit 43dab51
Show file tree

Hide file tree

Showing 44 changed files with 286 additions and 0 deletions.
diff --git a/packages/common/src/core/schemas/shared/subschemas.ts b/packages/common/src/core/schemas/shared/subschemas.ts
@@ -9,6 +9,14 @@ export const ENTITY_NAME_SCHEMA = {
   type: "string",
   minLength: 1,
   maxLength: 250,
+  format: "entityTitleValidator",
+};
+
+export const SITE_ENTITY_NAME_SCHEMA = {
+  type: "string",
+  minLength: 1,
+  maxLength: 250,
+  format: "siteEntityTitleValidator",
 };
 
 export const ENTITY_SUMMARY_SCHEMA = {

diff --git a/packages/common/src/discussions/_internal/DiscussionUiSchemaCreate.ts b/packages/common/src/discussions/_internal/DiscussionUiSchemaCreate.ts
@@ -33,6 +33,12 @@ export const buildUiSchema = async (
               icon: true,
               labelKey: `shared.fields.title.maxLengthError`,
             },
+            {
+              type: "ERROR",
+              keyword: "format",
+              icon: true,
+              labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+            },
           ],
         },
       },

diff --git a/packages/common/src/discussions/_internal/DiscussionUiSchemaEdit.ts b/packages/common/src/discussions/_internal/DiscussionUiSchemaEdit.ts
@@ -44,6 +44,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `shared.fields.title.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/groups/_internal/GroupUiSchemaCreate.ts b/packages/common/src/groups/_internal/GroupUiSchemaCreate.ts
@@ -46,6 +46,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/groups/_internal/GroupUiSchemaCreateAssociation.ts b/packages/common/src/groups/_internal/GroupUiSchemaCreateAssociation.ts
@@ -51,6 +51,12 @@ export const buildUiSchema = async (
                       icon: true,
                       labelKey: `${i18nScope}.fields.name.maxLengthError`,
                     },
+                    {
+                      type: "ERROR",
+                      keyword: "format",
+                      icon: true,
+                      labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                    },
                   ],
                 },
               },

diff --git a/packages/common/src/groups/_internal/GroupUiSchemaCreateEdit.ts b/packages/common/src/groups/_internal/GroupUiSchemaCreateEdit.ts
@@ -51,6 +51,12 @@ export const buildUiSchema = async (
                       icon: true,
                       labelKey: `${i18nScope}.fields.name.maxLengthError`,
                     },
+                    {
+                      type: "ERROR",
+                      keyword: "format",
+                      icon: true,
+                      labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                    },
                   ],
                 },
               },

diff --git a/packages/common/src/groups/_internal/GroupUiSchemaCreateFollowers.ts b/packages/common/src/groups/_internal/GroupUiSchemaCreateFollowers.ts
@@ -52,6 +52,12 @@ export const buildUiSchema = async (
                       icon: true,
                       labelKey: `${i18nScope}.fields.name.maxLengthError`,
                     },
+                    {
+                      type: "ERROR",
+                      keyword: "format",
+                      icon: true,
+                      labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                    },
                   ],
                 },
               },

diff --git a/packages/common/src/groups/_internal/GroupUiSchemaCreateView.ts b/packages/common/src/groups/_internal/GroupUiSchemaCreateView.ts
@@ -51,6 +51,12 @@ export const buildUiSchema = async (
                       icon: true,
                       labelKey: `${i18nScope}.fields.name.maxLengthError`,
                     },
+                    {
+                      type: "ERROR",
+                      keyword: "format",
+                      icon: true,
+                      labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                    },
                   ],
                 },
               },

diff --git a/packages/common/src/groups/_internal/GroupUiSchemaEdit.ts b/packages/common/src/groups/_internal/GroupUiSchemaEdit.ts
@@ -40,6 +40,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/initiative-templates/_internal/InitiativeTemplateUiSchemaEdit.ts b/packages/common/src/initiative-templates/_internal/InitiativeTemplateUiSchemaEdit.ts
@@ -47,6 +47,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `shared.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/initiatives/_internal/InitiativeUiSchemaCreate.ts b/packages/common/src/initiatives/_internal/InitiativeUiSchemaCreate.ts
@@ -54,6 +54,12 @@ export const buildUiSchema = async (
                           icon: true,
                           labelKey: `${i18nScope}.fields.name.maxLengthError`,
                         },
+                        {
+                          type: "ERROR",
+                          keyword: "format",
+                          icon: true,
+                          labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                        },
                       ],
                     },
                   },

diff --git a/packages/common/src/initiatives/_internal/InitiativeUiSchemaCreate2.ts b/packages/common/src/initiatives/_internal/InitiativeUiSchemaCreate2.ts
@@ -34,6 +34,12 @@ export const buildUiSchema = async (
               icon: true,
               labelKey: `${i18nScope}.fields.name.maxLengthError`,
             },
+            {
+              type: "ERROR",
+              keyword: "format",
+              icon: true,
+              labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+            },
           ],
         },
       },

diff --git a/packages/common/src/initiatives/_internal/InitiativeUiSchemaEdit.ts b/packages/common/src/initiatives/_internal/InitiativeUiSchemaEdit.ts
@@ -45,6 +45,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/pages/_internal/PageUiSchemaCreate.ts b/packages/common/src/pages/_internal/PageUiSchemaCreate.ts
@@ -34,6 +34,12 @@ export const buildUiSchema = async (
               icon: true,
               labelKey: `${i18nScope}.fields.name.maxLengthError`,
             },
+            {
+              type: "ERROR",
+              keyword: "format",
+              icon: true,
+              labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+            },
           ],
         },
       },

diff --git a/packages/common/src/pages/_internal/PageUiSchemaEdit.ts b/packages/common/src/pages/_internal/PageUiSchemaEdit.ts
@@ -44,6 +44,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/projects/_internal/ProjectUiSchemaCreate.ts b/packages/common/src/projects/_internal/ProjectUiSchemaCreate.ts
@@ -53,6 +53,12 @@ export const buildUiSchema = async (
                           icon: true,
                           labelKey: `${i18nScope}.fields.name.maxLengthError`,
                         },
+                        {
+                          type: "ERROR",
+                          keyword: "format",
+                          icon: true,
+                          labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                        },
                       ],
                     },
                   },

diff --git a/packages/common/src/projects/_internal/ProjectUiSchemaCreate2.ts b/packages/common/src/projects/_internal/ProjectUiSchemaCreate2.ts
@@ -34,6 +34,12 @@ export const buildUiSchema = async (
               icon: true,
               labelKey: `${i18nScope}.fields.name.maxLengthError`,
             },
+            {
+              type: "ERROR",
+              keyword: "format",
+              icon: true,
+              labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+            },
           ],
         },
       },

diff --git a/packages/common/src/projects/_internal/ProjectUiSchemaEdit.ts b/packages/common/src/projects/_internal/ProjectUiSchemaEdit.ts
@@ -46,6 +46,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/sites/_internal/SiteSchema.ts b/packages/common/src/sites/_internal/SiteSchema.ts
@@ -2,6 +2,7 @@ import { IAsyncConfigurationSchema } from "../../core";
 import {
   ENTITY_IS_DISCUSSABLE_SCHEMA,
   PRIVACY_CONFIG_SCHEMA,
+  SITE_ENTITY_NAME_SCHEMA,
 } from "../../core/schemas/shared";
 import { HubItemEntitySchema } from "../../core/schemas/shared/HubItemEntitySchema";
 
@@ -23,6 +24,7 @@ export const getSiteSchema = (siteId: string) =>
     ...HubItemEntitySchema,
     properties: {
       ...HubItemEntitySchema.properties,
+      name: SITE_ENTITY_NAME_SCHEMA,
       _discussions: ENTITY_IS_DISCUSSABLE_SCHEMA,
       telemetry: PRIVACY_CONFIG_SCHEMA,
       _urlInfo: {

diff --git a/packages/common/src/sites/_internal/SiteUiSchemaCreate.ts b/packages/common/src/sites/_internal/SiteUiSchemaCreate.ts
@@ -37,6 +37,12 @@ export const buildUiSchema = async (
               icon: true,
               labelKey: `${i18nScope}.fields.name.maxLengthError`,
             },
+            {
+              type: "ERROR",
+              keyword: "format",
+              icon: true,
+              labelKey: `${i18nScope}.fields.name.siteEntityTitleValidatorError`,
+            },
           ],
         },
       },

diff --git a/packages/common/src/sites/_internal/SiteUiSchemaEdit.ts b/packages/common/src/sites/_internal/SiteUiSchemaEdit.ts
@@ -44,6 +44,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.siteEntityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/surveys/_internal/SurveyUiSchemaEdit.ts b/packages/common/src/surveys/_internal/SurveyUiSchemaEdit.ts
@@ -41,6 +41,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `shared.fields.title.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/src/templates/_internal/TemplateUiSchemaEdit.ts b/packages/common/src/templates/_internal/TemplateUiSchemaEdit.ts
@@ -45,6 +45,12 @@ export const buildUiSchema = async (
                   icon: true,
                   labelKey: `${i18nScope}.fields.name.maxLengthError`,
                 },
+                {
+                  type: "ERROR",
+                  keyword: "format",
+                  icon: true,
+                  labelKey: `${i18nScope}.fields.name.entityTitleValidatorError`,
+                },
               ],
             },
           },

diff --git a/packages/common/test/discussions/_internal/DiscussionUiSchemaCreate.test.ts b/packages/common/test/discussions/_internal/DiscussionUiSchemaCreate.test.ts
@@ -25,6 +25,12 @@ describe("buildUiSchema: discussion create", () => {
                 icon: true,
                 labelKey: `shared.fields.title.maxLengthError`,
               },
+              {
+                type: "ERROR",
+                keyword: "format",
+                icon: true,
+                labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+              },
             ],
           },
         },

diff --git a/packages/common/test/discussions/_internal/DiscussionUiSchemaEdit.test.ts b/packages/common/test/discussions/_internal/DiscussionUiSchemaEdit.test.ts
@@ -68,6 +68,12 @@ describe("buildUiSchema: discussion edit", () => {
                     icon: true,
                     labelKey: "shared.fields.title.maxLengthError",
                   },
+                  {
+                    type: "ERROR",
+                    keyword: "format",
+                    icon: true,
+                    labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+                  },
                 ],
               },
             },
@@ -307,6 +313,12 @@ describe("buildUiSchema: discussion edit", () => {
                     icon: true,
                     labelKey: "shared.fields.title.maxLengthError",
                   },
+                  {
+                    type: "ERROR",
+                    keyword: "format",
+                    icon: true,
+                    labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+                  },
                 ],
               },
             },

diff --git a/packages/common/test/groups/_internal/GroupUiSchemaCreate.test.ts b/packages/common/test/groups/_internal/GroupUiSchemaCreate.test.ts
@@ -41,6 +41,12 @@ describe("GroupUiSchemaCreate", () => {
                       icon: true,
                       labelKey: `some.scope.fields.name.maxLengthError`,
                     },
+                    {
+                      type: "ERROR",
+                      keyword: "format",
+                      icon: true,
+                      labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+                    },
                   ],
                 },
               },

diff --git a/packages/common/test/groups/_internal/GroupUiSchemaCreateAssociation.test.ts b/packages/common/test/groups/_internal/GroupUiSchemaCreateAssociation.test.ts
@@ -48,6 +48,12 @@ describe("GroupUiSchemaCreateAssociation", () => {
                           icon: true,
                           labelKey: "some.scope.fields.name.maxLengthError",
                         },
+                        {
+                          type: "ERROR",
+                          keyword: "format",
+                          icon: true,
+                          labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+                        },
                       ],
                     },
                   },

diff --git a/packages/common/test/groups/_internal/GroupUiSchemaCreateEdit.test.ts b/packages/common/test/groups/_internal/GroupUiSchemaCreateEdit.test.ts
@@ -48,6 +48,12 @@ describe("GroupUiSchemaCreateEdit", () => {
                           icon: true,
                           labelKey: "some.scope.fields.name.maxLengthError",
                         },
+                        {
+                          type: "ERROR",
+                          keyword: "format",
+                          icon: true,
+                          labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+                        },
                       ],
                     },
                   },

diff --git a/packages/common/test/groups/_internal/GroupUiSchemaCreateFollowers.test.ts b/packages/common/test/groups/_internal/GroupUiSchemaCreateFollowers.test.ts
@@ -45,6 +45,12 @@ describe("GroupUiSchemaCreateFollowers", () => {
                           icon: true,
                           labelKey: "some.scope.fields.name.maxLengthError",
                         },
+                        {
+                          type: "ERROR",
+                          keyword: "format",
+                          icon: true,
+                          labelKey: `some.scope.fields.name.entityTitleValidatorError`,
+                        },
                       ],
                     },
                   },