-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
centroid fixes #227
centroid fixes #227
Conversation
I've fixed travis build for openjdk. Have problem with oracle. |
I've added openjdk14 for which I've updated the source and target of java to 1.7 |
I've commented out oracle jdk from travis.yml. Now the checks pass. Please, let me know if there is other way to fix the Travis CI build. |
@stolstov By any chance does the Travis build work with Oracle-JDK-11? I wouldn't worry about 9 or 10 which are obsoleted by 11. |
@randallwhitman Thanks, oraclejdk11 works indeed. I'll leave it at that. |
Sounds good. Only remaining suggestion about that would be to likewise upgrade OpenJDK to 11 and forget 9-10. |
It builds openjdk 9,10, and 14 right now. |
@stolstov I added a few test cases to your branch. It looks good to me. |
@alocke Thank you. I'll install this tomorrow if I don't hear negative feedback. |
Version 2.2.3 has two fixes of interest: correct computation of centroids of very small polygons - Esri/geometry-api-java#227 correct computation of buffers around small polygons - Esri/geometry-api-java#243
In Esri v2.2.3, the centroid calculate includes centroid fixes for degenerate (near dimension 1) polygons (Esri/geometry-api-java#227). This replaces our implemenation (which the original Esri implemenation was based on) with the fixed Esri version. Fixes prestodb#10629
Version 2.2.3 has two fixes of interest: correct computation of centroids of very small polygons - Esri/geometry-api-java#227 correct computation of buffers around small polygons - Esri/geometry-api-java#243
In Esri v2.2.3, the centroid calculate includes centroid fixes for degenerate (near dimension 1) polygons (Esri/geometry-api-java#227). This replaces our implemenation (which the original Esri implemenation was based on) with the fixed Esri version. Fixes #10629
Version 2.2.3 has two fixes of interest: correct computation of centroids of very small polygons - Esri/geometry-api-java#227 correct computation of buffers around small polygons - Esri/geometry-api-java#243
In Esri v2.2.3, the centroid calculate includes centroid fixes for degenerate (near dimension 1) polygons (Esri/geometry-api-java#227). This replaces our implemenation (which the original Esri implemenation was based on) with the fixed Esri version. Fixes prestodb#10629
Issue: #225
Fix polyline centroid (original would only take endpoints of polyline paths)
Zero area polygon delegates to the polyline centroid and zero length polyline delegates to the multipoint centroid.
Rewrite polygon centroid for better accuracy.
@jagill I've copied your test cases
@mbasmanova
@alocke