Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centroid fixes #227

Merged
merged 13 commits into from
Aug 3, 2019
Merged

centroid fixes #227

merged 13 commits into from
Aug 3, 2019

Conversation

stolstov
Copy link
Member

Issue: #225

Fix polyline centroid (original would only take endpoints of polyline paths)
Zero area polygon delegates to the polyline centroid and zero length polyline delegates to the multipoint centroid.
Rewrite polygon centroid for better accuracy.

@jagill I've copied your test cases
@mbasmanova
@alocke

@stolstov
Copy link
Member Author

I've fixed travis build for openjdk. Have problem with oracle.
For the oraclejdk9
Unresolveable build extension: Plugin org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8 or one of its dependencies could not be resolved

@stolstov
Copy link
Member Author

I've added openjdk14 for which I've updated the source and target of java to 1.7
Travis has some new error with oraclejdk. I don't know how to fix this:
Unresolveable build extension: Plugin org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8 or one of its dependencies could not be resolved: Failed to read artifact descriptor for org.sonatype.plugins:nexus-staging-maven-plugin:jar:1.6.8

@stolstov
Copy link
Member Author

I've commented out oracle jdk from travis.yml. Now the checks pass. Please, let me know if there is other way to fix the Travis CI build.

@randallwhitman
Copy link
Contributor

@stolstov By any chance does the Travis build work with Oracle-JDK-11? I wouldn't worry about 9 or 10 which are obsoleted by 11.

@stolstov
Copy link
Member Author

@randallwhitman Thanks, oraclejdk11 works indeed. I'll leave it at that.

@randallwhitman
Copy link
Contributor

Sounds good. Only remaining suggestion about that would be to likewise upgrade OpenJDK to 11 and forget 9-10.

@stolstov
Copy link
Member Author

It builds openjdk 9,10, and 14 right now.

@alocke
Copy link
Member

alocke commented Jul 31, 2019

@stolstov I added a few test cases to your branch. It looks good to me.

@stolstov
Copy link
Member Author

@alocke Thank you. I'll install this tomorrow if I don't hear negative feedback.

jagill added a commit to jagill/presto that referenced this pull request Sep 3, 2019
Version 2.2.3 has two fixes of interest:

correct computation of centroids of very small polygons - Esri/geometry-api-java#227
correct computation of buffers around small polygons - Esri/geometry-api-java#243
jagill added a commit to jagill/presto that referenced this pull request Sep 3, 2019
In Esri v2.2.3, the centroid calculate includes centroid fixes for
degenerate (near dimension 1) polygons (Esri/geometry-api-java#227).
This replaces our implemenation (which the original Esri implemenation
was based on) with the fixed Esri version.

Fixes prestodb#10629
mbasmanova pushed a commit to prestodb/presto that referenced this pull request Sep 4, 2019
Version 2.2.3 has two fixes of interest:

correct computation of centroids of very small polygons - Esri/geometry-api-java#227
correct computation of buffers around small polygons - Esri/geometry-api-java#243
mbasmanova pushed a commit to prestodb/presto that referenced this pull request Sep 4, 2019
In Esri v2.2.3, the centroid calculate includes centroid fixes for
degenerate (near dimension 1) polygons (Esri/geometry-api-java#227).
This replaces our implemenation (which the original Esri implemenation
was based on) with the fixed Esri version.

Fixes #10629
kaikalur pushed a commit to kaikalur/presto that referenced this pull request Jan 22, 2020
Version 2.2.3 has two fixes of interest:

correct computation of centroids of very small polygons - Esri/geometry-api-java#227
correct computation of buffers around small polygons - Esri/geometry-api-java#243
kaikalur pushed a commit to kaikalur/presto that referenced this pull request Jan 22, 2020
In Esri v2.2.3, the centroid calculate includes centroid fixes for
degenerate (near dimension 1) polygons (Esri/geometry-api-java#227).
This replaces our implemenation (which the original Esri implemenation
was based on) with the fixed Esri version.

Fixes prestodb#10629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants