Fix toLatLngBounds was not found in 'leaflet'

[fuhidev]

export 'toLatLngBounds' (imported as 'latLngBounds') was not found in 'leaflet'

[gavinr]

Thank you for the PR!. This is a potential fix for #1342. We'll test this soon.

[pavch]

waiting eagerly this fix

[gavinr]

Hi, we are hoping that the fixes happening in leaflet (Leaflet/Leaflet#8451 / Leaflet/Leaflet#8493) will resolve this without this PR being required. If the leaflet 1.9 patch does not resolve it, we will look more into this solution in this PR. Thanks for your patience!

[pavch]

Hey! What about compatibility with older versions of Leaflet?

[addy]

@gavinr I saw Leaflet released 1.9.1 which doesn't seem to fix the issue :\

[gavinr]

Leaflet released v1.9.2 a few hours ago: https://github.com/Leaflet/Leaflet/releases/tag/v1.9.2

And I have tested that using 1.9.2 (instead of 1.9.0 or 1.9.1) fixes the issue #1342, so I think the solution is for anyone who wants to use leaflet v1.9 to use >=1.9.2 .... and this PR can be closed without merging. I will close this soon unless I hear any major objections.

Thanks!

[gavinr]

I am assuming this is resolved if using leaflet v1.9.2 (#1342 (comment)). If not, please comment or open a new issue. Thank you!

[mbostock]

This still seems to be broken. Here is a simple reproduction using jsDelivr’s +esm service:

import("https://cdn.jsdelivr.net/npm/esri-leaflet/+esm")

This generates an error:

SyntaxError: The requested module '/npm/[email protected]/+esm' does not provide an export named 'toLatLngBounds'

[gavinr]

@mbostock thanks for digging up this issue to report this item. I did a bit of research here:

I do not get this error when installing via NPM and using the ES modules that way, for example here: https://github.com/gavinr-maps/esri-leaflet-react-demo. Is that the same for you?

So then the issue is when using ES modules via <script type="module" with these common CDNs (e.g. Skypack, esm.sh, or jsdeliver.net.../+esm). I can confirm that I am getting the same error as you when using those. Replication cases:

• esm.sh: https://jsbin.com/nuwoqiyiku/4/edit?html,output - error Uncaught SyntaxError: The requested module '/v135/[email protected]/es2022/leaflet.mjs' does not provide an export named 'toLatLngBounds'
• cdn.jsdelivr.net...../+esm - https://jsbin.com/nuwoqiyiku/6/edit?html,output - error Uncaught SyntaxError: The requested module '/npm/[email protected]/+esm' does not provide an export named 'toLatLngBounds'
• Skypack: https://jsbin.com/nuwoqiyiku/2/edit?html,output - works fine, oddly. But skypack is abandoned so I think the above 2 errors are more indicative of the problem.

So I do think this is a slightly different (but similar) issue than the original issue here... It would probably be good to open a new issue, focusing on the error when using ESM url CDNs.