Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(combobox): allow arrow selection of entered text #9629

Merged
merged 6 commits into from
Jun 21, 2024
Merged

fix(combobox): allow arrow selection of entered text #9629

merged 6 commits into from
Jun 21, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 18, 2024 •
edited
Loading

Related Issue: #9614

Summary

  • fix to allow arrow keys to work to navigate text. (left/right/up/down)
    • checks the selectionIndex or whether a chip is selected to do so
    • arrow up and arrow down work when no filtered items are available
  • Adds test
  • Adds utility function for future use

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 18, 2024
@driskull driskull marked this pull request as ready for review June 18, 2024 17:12
@driskull driskull requested a review from a team as a code owner June 18, 2024 17:12
@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 20, 2024
jcfranco
jcfranco approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕
🥕🥕🐰🐰🐰🥕🐰🥕🥕🥕🥕🥕🐰🥕🐰🐰🐰🐰🥕🐰🐰🐰🐰🥕🐰🐰🐰🐰🐰🥕🐰🥕
🥕🐰🥕🥕🥕🥕🐰🥕🥕🥕🥕🥕🐰🥕🐰🥕🥕🥕🥕🐰🥕🥕🥕🥕🥕🥕🐰🥕🥕🥕🐰🥕
🥕🥕🐰🐰🥕🥕🐰🥕🥕🐰🥕🥕🐰🥕🐰🐰🐰🥕🥕🐰🐰🐰🥕🥕🥕🥕🐰🥕🥕🥕🐰🥕
🥕🥕🥕🥕🐰🥕🐰🥕🐰🥕🐰🥕🐰🥕🐰🥕🥕🥕🥕🐰🥕🥕🥕🥕🥕🥕🐰🥕🥕🥕🥕🥕
🥕🐰🐰🐰🥕🥕🥕🐰🥕🥕🥕🐰🥕🥕🐰🐰🐰🐰🥕🐰🐰🐰🐰🥕🥕🥕🐰🥕🥕🥕🐰🥕
🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕🥕

Awesome! Thanks for extracting that test util. It'll come in handy! 🔧

packages/calcite-components/src/tests/commonTests/utils.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/tests/commonTests/utils.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/tests/commonTests/utils.ts Outdated Show resolved Hide resolved
packages/calcite-components/src/tests/commonTests/utils.ts Outdated Show resolved Hide resolved
@driskull driskull merged commit df5e654 into dev Jun 21, 2024
9 checks passed
@driskull driskull deleted the dris0000/combobox-arrow-key-selection-fix branch June 21, 2024 15:31
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 21, 2024
benelan added a commit that referenced this pull request Jun 24, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/release-ci-imp…
384b1b5 
…rovements

* origin/dev:
  build(deps): update typescript-eslint monorepo to v7.13.1 (#9657)
  docs: update component READMEs (#9668)
  chore: release next
  chore: minor git tooling tweaks (#9664)
  feat(combobox): add `filterText` prop (#9654)
  chore: release next
  feat(list): add filterProps property to specify which properties to filter against (#9622)
  chore: release next
  fix(list): enable dragging on list items contained within a list that supports dragEnabled (#9660)
  test(filter): add coverage for empty filter text (#9655)
  chore: release next
  fix: set the correct Sortable parent when within a shadowRoot (#9532)
  fix(combobox): allow arrow selection of entered text (#9629)
@benelan benelan mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco