Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu, menu-item): Adds menu & menu-item components. #6901
feat(menu, menu-item): Adds menu & menu-item components. #6901
Changes from 32 commits
4a60b88
29a9822
cdb6238
15392ce
a30cd27
a8ba656
47f6e44
cb9c37f
d972bdb
5f21d0b
4a72f5f
de88018
96298be
e8a25a8
d153f37
b09d8aa
9ef8b37
fc38b1f
8725ed3
71a58e6
eed1631
d2bfa3d
bf4a06a
7dbfc7e
e0f8c5f
7bf6557
a98d8f0
a8bd6d9
a4a7f94
f44308c
9353872
4d09582
5167d55
3d09c64
56d9d26
43f9076
9dcafc1
cff5c89
aed03cf
5fe121d
142e4fe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being caused by the click-handling element (anchor) not stretching along with its host and therefore not being in the center when the click happens (
E2EElement.click()
scrolls and clicks on the center of the element). If you setinline-size: 100%
on the anchor, it fixes the test, but not sure if that will cause layout issues (design-wise).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. we can mark
inline-size:100%
for anchor element and the design will be similar.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revisit this later to reduce specificity. This also bypasses the way we've been applying our BEM-like™ classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't the
iconsBoth
story cover bothiconStart
andiconEnd
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for keeping this is to verify how the
iconEnd
alone works in terms of spacing.