Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some properties (e.g. inputMode not available anymore) #9235

Closed
2 of 6 tasks
hcampos-professional opened this issue May 1, 2024 · 9 comments
Closed
2 of 6 tasks

Some properties (e.g. inputMode not available anymore) #9235

hcampos-professional opened this issue May 1, 2024 · 9 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p0 - emergency User set priority impact status of p0 - emergency p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-05-15 - 2.8....

Comments

@hcampos-professional
Copy link

Check existing issues

Actual Behavior

While testing the latest v2.8.0 of Calcite Components together with the JSAPI, the Typescript compiler reported that inputMode is no longer available as a property of <calcite-input-number>. It seems like the change got introduced by 13ba953 and it could affect apps using that property or any of the other properties that were removed.

Expected Behavior

Typings should still contain the previously-existing properties. Alternatively, a breaking change and consequent major version should be released.

Reproduction Sample

https://codepen.io/hccampos/pen/ExJzRRq

Reproduction Steps

  1. Open https://codepen.io/hccampos/pen/ExJzRRq
  2. Inspect the input element.
  3. Type $0.inputMode in the console and notice that the inputMode property isn't set.

Alternatively, build an application which makes use of the typings and notice that the property isn't available.

Reproduction Version

2.8.0

Relevant Info

No response

Regression?

2.7.x

Priority impact

p0 - emergency

Impact

While it doesn't directly impact my team (we haven't decided if we'll upgrade to this version of Calcite for the upcoming release), it can potentially affect any application which was using one of the removed properties. Their builds can fail and the components may not work as expected.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@hcampos-professional hcampos-professional added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 1, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p0 - emergency User set priority impact status of p0 - emergency labels May 1, 2024
@geospatialem geospatialem added estimate - 2 Small fix or update, may require updates to tests. p - critical Issue preventing EVERYONE from using a component or core functionality and removed needs triage Planning workflow - pending design/dev review. labels May 1, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 1, 2024
driskull added a commit that referenced this issue May 1, 2024
@driskull
revert: restore some ESLint rules #9235
a90d1fd
@driskull driskull mentioned this issue May 1, 2024
Closed
@geospatialem
Copy link
Member

Closing out the above as the global attributes are provided and the issue for Maps SDK for JS appears to be related to the maquette VDOM library typings for globals.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
@jcfranco
Copy link
Member

jcfranco commented May 2, 2024

One thing that #9123 overlooked was how our custom global component prop's were using the kebabified™ case vs the native ones. I think we can add props (@internal) for enterKeyHint and inputMode to allow the VDOM typing tool referenced above to do proper attribute mapping. We can drop support for the kebab-case attributes in 3.x.

@geospatialem geospatialem assigned jcfranco and unassigned driskull May 2, 2024
@geospatialem
Copy link
Member

Reopening to provide support to kebab-case per Franco's comment above.

@geospatialem geospatialem reopened this May 2, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - critical Issue preventing EVERYONE from using a component or core functionality labels May 2, 2024
@jcfranco jcfranco mentioned this issue May 2, 2024
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 3, 2024
jcfranco added a commit that referenced this issue May 3, 2024
@jcfranco
fix(input, input-number, input-text): restore autofocus, `enter-key…
a493664 
…-mode` and `input-mode` attributes (#9245)

**Related Issue:** #9235

## Summary

This fixes the following issues introduced by #9123 when component props
that shadowed global attributes were removed:

* the kebab-cased attribute names of those props would no longer work
(namely, `enter-key-mode`, `input-mode`)
* `autofocus` was missing from component types as Stencil does not
include it in the base `HTMLAttribute` type (see
ionic-team/stencil#5726).
jcfranco added a commit that referenced this issue May 10, 2024
@jcfranco @benelan
fix(input, input-number, input-text): restore autofocus, `enter-key…
0498c6e 
…-mode` and `input-mode` attributes (#9245) (#9306)

**Related Issue:** #9235

## Summary

This fixes the following issues introduced by #9123 when component props
that shadowed global attributes were removed:

* the kebab-cased attribute names of those props would no longer work
(namely, `enter-key-mode`, `input-mode`)
* `autofocus` was missing from component types as Stencil does not
include it in the base `HTMLAttribute` type (see
ionic-team/stencil#5726).

Co-authored-by: Ben Elan <[email protected]>
@DitwanP
Copy link
Contributor

DitwanP commented May 13, 2024

🍡 Verified locally on hotfix

@DitwanP DitwanP closed this as completed May 13, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 13, 2024
@jcfranco jcfranco mentioned this issue May 14, 2024
Merged
jcfranco added a commit that referenced this issue May 15, 2024
@jcfranco
fix(input, input-number, input-text): ensure autofocus is available o…
405a4b0 
…n HTMLElement (#9343)

**Related Issue:** #9235

## Summary

Exposes `autofocus` property to ensure the prop/attr is available on the
`HTMLElement` type.

This should no longer be necessary once
ionic-team/stencil#5726 is fixed and available
in Stencil.
@jcfranco
Copy link
Member

Reopening due to autofocus prop/attr type issue. Using @internal removes the prop/attr from components.d.ts and due to ionic-team/stencil#5726 the type cannot be resolved (inputMode and enterKeyHint do not have this issue).

cc @AdelheidF

@jcfranco jcfranco reopened this May 15, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 4 - verified Issues that have been released and confirmed resolved. labels May 15, 2024
@jcfranco jcfranco assigned jcfranco and unassigned geospatialem and DitwanP May 15, 2024
@jcfranco jcfranco added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label May 15, 2024
@github-actions github-actions bot removed the 2 - in development Issues that are actively being worked on. label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco May 15, 2024
@jcfranco
Copy link
Member

Repro case: https://github.com/jcfranco/cc-autofocus-missing-from-types

benelan pushed a commit that referenced this issue May 15, 2024
@jcfranco @benelan
fix(input, input-number, input-text): ensure autofocus is available o…
ecc97a9 
…n HTMLElement (#9343)

**Related Issue:** #9235

## Summary

Exposes `autofocus` property to ensure the prop/attr is available on the
`HTMLElement` type.

This should no longer be necessary once
ionic-team/stencil#5726 is fixed and available
in Stencil.
@benelan benelan mentioned this issue May 15, 2024
Merged
benelan added a commit that referenced this issue May 15, 2024
@benelan @jcfranco
fix(input, input-number, input-text): ensure autofocus is available o…
27ad10e 
…n HTMLElement (#9343) (#9347)

**Related Issue:** #9235

## Summary

Exposes `autofocus` property to ensure the prop/attr is available on the
`HTMLElement` type.

This should no longer be necessary once
ionic-team/stencil#5726 is fixed and available
in Stencil.

Co-authored-by: JC Franco <[email protected]>
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 15, 2024
@geospatialem
Copy link
Member

Verified with https://github.com/jcfranco/cc-autofocus-missing-from-types in 2.8.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p0 - emergency User set priority impact status of p0 - emergency p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-05-15 - 2.8.2 April hotfix release
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @DitwanP @hcampos-professional