View options #203

[jwasilgeo]

@tomwayson please review; resolves #203.

I found that it was crucial to keep your original work with getting an immediate reference to a promise for esriLoading a MapView or SceneView module. Without this--and instead AMD loading within the setMap method--sometimes I'd find myself outside of the Angular digest cycle and nothing would load in a <esri-*-view> directive.

Ultimately, this code now constructs a new MapView or SceneView with all options + a valid map instance inside of the setMap method.

Otherwise, just for illustration, I added a button to change the map property for the scene-view and feature-layer test pages. You'll see that the feature-layer test page will not behave 💯% right when attempting to change the map property, and I think this has to do with the original map having layers. Remove the layers yourself in the sample code, run it again, and then it should be fine when switching out the map.

[tomwayson]

@jwasil I really want to merge this, and #207 - both look good and I appreciate all the thought you've put into these issues.

Only thing holding me back is "You'll see that the feature-layer test page will not behave 💯% right when attempting to change the map property" - I tried this, and for me, it seemed like I had to click the button twice to change the map, which, as you say, is not 100% right. I tried removing the call to esriLoader.require() and directly setting the map on the map view in changeMap (see below), but it made no difference.

                        self.changeMap = function() {
                            // create the map
                            // and add a feature layer
                            console.log('changeMap');
                            self.mapView.map = new Map({
                                basemap: 'gray'
                            });
                        };

Have you tried switching maps outside of Angular (i.e. in a fiddle)? If it works outside of Angular, I think we ought to keep digging into this.

What do you think?

[jwasilgeo]

@tomwayson check this out, outside of Angular: https://jsfiddle.net/jwasil/ooyqymwe/

I still think the culprit is a MapView with a Map that has a FeatureLayer(s) on it. When you try to replace a Map with layers, you'll see it has trouble during teardown (?) while switching the map property on the MapView.

Seems to be fine if dealing with SceneViews, regardless of the underlying map having layers.

PS: I'll push some code cleanup, too. Good point in that we don't need another esriLoader.require.