This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
V2 beta 1 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on JSAPI v4beta3 includes test and example pages for - feature layer in a 2d map view - scene view - home button widget remove all non JSAPI 4 tests, examples, etc
…ng "view-options" binding on view directives; adding documentation; resolves #191
…amples and test pages; added safety checks to setMap and setView methods; resolves #195
I know it's a bit akward for scene view to be under map module/folder, but I thought it would be better to keep the module name (esri.map) consistent with previous versions and with the repo name (angular-esri-map) and output file name (angular-esri-map.js). This reverts commit f49f4e5. Conflicts: gulpfile.js test/feature-layer.html Also moved home button directive files from src/directives to src/map folder.
Thanks for the final review and updates! Were you also able to see how the esriMapView doesn't really like to accept bound "view-options", whereas the esriSceneView seems to be ok with it? It is creeping me out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomwayson please review. This picks up from your original work on v2-beta-1 (awesome stuff!!), and includes changes to resolve #190, #191, #192, and #195. As far as big changes that need some review for sure:
setMap
method.