Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

V2 beta 1 #198

Merged
merged 10 commits into from
Jan 10, 2016
Merged

V2 beta 1 #198

merged 10 commits into from
Jan 10, 2016

Conversation

jwasilgeo
Copy link
Contributor

@tomwayson please review. This picks up from your original work on v2-beta-1 (awesome stuff!!), and includes changes to resolve #190, #191, #192, and #195. As far as big changes that need some review for sure:

  • esri.map doesn't exist anymore --> changed to esri.directives
  • changed the isolate scope properties for directives
    • The map view and scene view all get isolate "view-options", which works great for scene views but is still mysteriously not working right for map views. In the case of a map view, we still use your original safety checks for the initial extent, but any other valid JSAPI properties like rotation, center, zoom, etc. are not applied to the map view during the setMap method.
  • esriHomeButton also is a little different, but certainly inspired by, your original home button example

tomwayson and others added 10 commits December 23, 2015 15:23
based on JSAPI v4beta3

includes test and example pages for
- feature layer in a 2d map view
- scene view
- home button widget

remove all non JSAPI 4 tests, examples, etc
…ng "view-options" binding on view directives; adding documentation; resolves #191
…amples and test pages; added safety checks to setMap and setView methods; resolves #195
I know it's a bit akward for scene view to be under map module/folder, but
I thought it would be better to keep the module name (esri.map) consistent
with previous versions and with the repo name (angular-esri-map)
and output file name (angular-esri-map.js).

This reverts commit f49f4e5.

Conflicts:
	gulpfile.js
	test/feature-layer.html

Also moved home button directive files from src/directives to src/map folder.
@tomwayson
Copy link
Member

excellent work @jwasil.

I ended up reverting f49f4e5 for the reasons listed in 821a337.

resolves #190
resolves #191
resolves #192
resolves #195

tomwayson added a commit that referenced this pull request Jan 10, 2016
@tomwayson tomwayson merged commit c394e99 into master Jan 10, 2016
@tomwayson tomwayson deleted the v2-beta-1 branch January 10, 2016 21:17
@tomwayson tomwayson mentioned this pull request Jan 10, 2016
@jwasilgeo
Copy link
Contributor Author

Thanks for the final review and updates! Were you also able to see how the esriMapView doesn't really like to accept bound "view-options", whereas the esriSceneView seems to be ok with it? It is creeping me out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default bootstrap to use JSAPI v4 beta 3
2 participants