Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

draft vector tile directive with example #173

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

snodnipper
Copy link
Contributor

quick stab at adding a vector tile directive. Perhaps this is something folk can refine?

I note that the lifecycle doesn't behave quite right - I seem to need to click onto, say, 'Set Basemap' before 'Vector Basemap'. Perhaps someone can comment.

Happy to rebase as necessary.

@tomwayson tomwayson added this to the v1.1 milestone Dec 13, 2015
@tomwayson
Copy link
Member

@snodnipper

Thank you for this thorough contribution (including docs!). I definitely plan to merge this, but I've been seeing the same issues you mention above and haven't had time to dig into it yet.

@jwasil this is on the roadmap now, so whomever gets a chance to work on it first should just self-assign this PR.

@snodnipper
Copy link
Contributor Author

No worries Tom - glad you found it useful. I will be keen to see what the issue is.

@jwasilgeo jwasilgeo self-assigned this Dec 16, 2015
@jwasilgeo
Copy link
Contributor

@snodnipper I'd like to echo @tomwayson's comment: thanks for your work on this! I have been investigating and have some thoughts on what is causing this. I'll let you know when I have some commits of some changes worth mentioning pretty soon.

@jwasilgeo jwasilgeo merged commit 4f78462 into Esri:master Dec 18, 2015
@jwasilgeo
Copy link
Contributor

Refer to #182 for more info.

@tomwayson
Copy link
Member

Thanks again @snodnipper!

@snodnipper
Copy link
Contributor Author

Np guys! Happy Christmas and may 2016 be full of Angular 2 gorgeousness!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants