Unit tests for esri.core services #150
Conversation
add unit tests for esriMapUtils: - check for mapOptions before normalizing extent - fixed thumbnailurl typo in test/site pages - test for normailzed extent - TODO: tests for createWebMap fail also added ngdocs for esriMapUtils added tests for esriLoader.require - TODO: tests for esriLoader.bootstrap()? esriLayerUtils tests now use mock deferred added tests for esriRegistry
gulp test now runs unit tests in chrome and generates an istanbul code coverage report in test/unit/coverage
|
@tomwayson reviewing now and will push some stuff soon. You'll love the "fix" to get createWebMap tests running. EDIT: Well, hold on, maybe something I noticed was actually on purpose. In-line comment forthcoming in a few seconds... |
… (partially for my own education of unit testing in this repo)
| }); | ||
|
|
||
| // TODO: tests for create web map not working | ||
| xdescribe('createWebMap', function() { |
There was a problem hiding this comment.
@tomwayson was "xdescribe" on purpose to stop these tests from running? I played around with these and also couldn't get the actual expects to show up in the test runners either way.
There was a problem hiding this comment.
Yeah. Just skipping this until we figure out the issue. Also, I was thrashing around a bit trying different ways of getting it working and it doesn't even look like I checked in the code I expected to work.
There was a problem hiding this comment.
Understood, thanks. Safe to go ahead and merge, or does that mean you might want to add some more?
Unit tests for esri.core services
Resolves #146
Couldn't get tests to work for
esriMapUtils.createWebMap(), but those can be added later. Otherwise I'm happy w/ the tests for the loader and map and layer utils.@jwasil please review and merge at will.