This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
Move core services into their own module #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new folder structure - core - layers - map core includes: - esriLoader - esriRegistry - esriMapUtils - esriLayerUtils moved instance-specific code from esriLayerUtils into a base controller other layer controllers extend this base controller for shared functions build core module into it's own file
based on the blend renderer sample
Resolves #69 @jwasil please review, specifically:
|
Closed
tomwayson
changed the title
Breaks core services out into their own module
Move core services into their own module
Nov 5, 2015
…ome binding for custom directive example; layerInfo.hideLayers number conversion
Wonderful work here! Great updates through and through.
Thoughts on above items or what was pushed in 217e818, @tomwayson? |
Closed
tomwayson
added a commit
that referenced
this pull request
Nov 7, 2015
Move core services into their own module
@jwasil thanks for the thorough review. I like your additions and have merged them (after a few minor changes to names and wording). Thoughts:
The v.1 API is now complete! Let's add some tests, docs, and put a bow on this thing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created esri.core module as a dependency of esri.map.
Added a test page to demonstrate using the core module to define your own directive.