This repository has been archived by the owner on Dec 1, 2020. It is now read-only.
Feature layer options #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 16, 2015 07:47
…structor options to be passed in; added some extended comments for upcoming documentation; moved definitionExpression from $attrs to $scope for future watch changes esriMap: inspired by additions to esriFeatureLayer, so added an additional check during infoWindow Popup construction; also added more comments for upcoming docs
…nality; misc. comment update in esriMap
…re layer, and some documentation to the feature-layers example page; modified var names for additional readability
|
Well done @jwasil! Very thorough and thoughtful implementation. I agree that the Feature Layers example page is a little bit busy now, but I don't have any suggestions as to how to simplify it, or break it up at this time. We can open an issue for this later if needed. |
|
Thanks for the review and feedback! I appreciate it. Yeah, wrt Feature Layers, maybe something like an example with no (or few) esriFeatureLayer options, and another example with a combination of more options; but as you said, later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomwayson please review. I modified the feature-layers example docs page a bit in 8515ae4, and perhaps even replicated too much functionality from the related test page. Feel free to suggest cutting something from that.
The changelog has also been updated. gh-pages should be updated after this PR as well.
Resolves #97 and #100.
Thanks!