Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit/improve KZG10 code #62

Closed
zhenfeizhang opened this issue May 3, 2022 · 2 comments · Fixed by #116
Closed

audit/improve KZG10 code #62

zhenfeizhang opened this issue May 3, 2022 · 2 comments · Fixed by #116
Assignees
@mrain

Comments

@zhenfeizhang
Copy link
Contributor

the main bottleneck of Jellyfish currently are:

  • FFT
  • KZG commitment

And KZG dominants.

It appears that arkwork's KZG implementation may not be optimized, for example:
arkworks-rs/poly-commit#98

The non-optimization in the example is not critical to us yet because it is for the verifier, and CAPE uses solidity verifier rather than rust verifier (cc @philippecamacho).
@zhenfeizhang
Copy link
Contributor Author

zhenfeizhang commented Jul 28, 2022 •
edited
Loading

FYI: @alxiong here is the issue.

Resolution: we will use our own PCS APIs for this.

@mrain mrain self-assigned this Aug 1, 2022
@chancharles92 chancharles92 mentioned this issue Aug 2, 2022
Open
@zhenfeizhang
Copy link
Contributor Author

  • move HP PCS to Jellyfish/primitive
  • update Jellyfish/plonk to new PCS
  • implement univariate KZG batching for PCS (different PR)
  • update jellyfish/plonk with pcs batching (different PR)

@mrain mrain mentioned this issue Aug 26, 2022
Merged
6 tasks
@mrain mrain linked a pull request Aug 26, 2022 that will close this issue
New PCS trait and implementation #116
Merged
6 tasks
@mrain mrain closed this as completed in #116 Sep 1, 2022
mrain added a commit that referenced this issue Sep 1, 2022
@mrain
New PCS trait and implementation (#116)
ff43209 
closes: #62 

- Introduct new `PolynomialCommitmentScheme` trait and basic implementations
- Now `PlonkKzgSnark` use our own KZG10 implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrain mrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New PCS trait and implementation EspressoSystems/jellyfish
2 participants
@mrain @zhenfeizhang