This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Arbitrum goerli preparations #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove funding the deployer from all tokens except SimpleToken. - Add instructions for how to deploy tokens to arbitrum. - Use 6 decimals for USDC and the default (18) for the others.
Ancient123
approved these changes
Nov 30, 2022
|
Looks like the wallet changes that are/were needed. |
|
@philippecamacho I'm not quite sure why the test is flaky. It works fine at the beginning but starts failing after geth is running for a while. 🤷 removed the expect for now. |
|
@philippecamacho @sveitser @jbearer I deployed the token contracts to arbitrum goerli and added an updated official asset library toml. I think @Ancient123 needs to run the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1238.
I also think this are all the changes needed in this repo to update the wallet docker image for #1237 (cc @Ancient123)
edit: I forgot about the official asset library, added that to #1237.
If this is okay I will deploy the tokens and commit the deployment artifacts.