Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Eqs remove unbounded queries #1191

Merged
merged 4 commits into from
Jul 12, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Problem: unbounded get_all_nullifiers endpoint
The endpoint is unused, remove it.
sveitser committed Jul 12, 2022
commit 5e82cba3eff1def97313f24e2eb0ece3969da1e0
4 changes: 0 additions & 4 deletions eqs/api/api.toml
Original file line number Diff line number Diff line change
@@ -35,10 +35,6 @@ HEADING_DESCRIPTION = "Description"
PATH = [ "get_cap_state" ]
DOC = "Returns the current CAP blockchain state."

[route.get_all_nullifiers]
PATH = [ "get_all_nullifiers" ]
DOC = "Returns the current set of nullifiers."

[route.check_nullifier]
PATH = [ "check_nullifier/:nullifier" ]
":nullifier" = "TaggedBase64"
11 changes: 1 addition & 10 deletions eqs/src/routes.rs
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ use jf_cap::structs::{AssetCode, Nullifier};
use net::server::response;
use seahorse::events::LedgerEvent;
use serde::{Deserialize, Serialize};
use std::collections::{HashMap, HashSet};
use std::collections::HashMap;
use std::str::FromStr;
use strum::IntoEnumIterator;
use strum_macros::{AsRefStr, EnumIter, EnumString};
@@ -29,7 +29,6 @@ const EQS_MAX_EVENT_COUNT: usize = 100;
#[derive(AsRefStr, Copy, Clone, Debug, EnumIter, EnumString)]
pub enum ApiRouteKey {
get_cap_state,
get_all_nullifiers,
check_nullifier,
get_events_since,
get_transaction,
@@ -107,13 +106,6 @@ pub async fn get_cap_state(query_result_state: &QueryResultState) -> Result<CapS
})
}

/// Obtain all the nullifiers that have been published in the CAPE contract.
pub async fn get_all_nullifiers(
query_result_state: &QueryResultState,
) -> Result<HashSet<Nullifier>, tide::Error> {
Ok(query_result_state.nullifiers.clone())
}

/// Check if a nullifier has already been published.
pub async fn check_nullifier(
bindings: &HashMap<String, RouteBinding>,
@@ -234,7 +226,6 @@ pub async fn dispatch_url(
let query_state = &*query_state_guard;
match key {
ApiRouteKey::get_cap_state => response(&req, get_cap_state(query_state).await?),
ApiRouteKey::get_all_nullifiers => response(&req, get_all_nullifiers(query_state).await?),
ApiRouteKey::check_nullifier => {
response(&req, check_nullifier(bindings, query_state).await?)
}