Use public member instead of private field to resolve immutability #567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current com.esotericsoftware.kryo.Serializer::copy function determines immutability through its private field instead of it's public isImmutable() member (which docs actually mention). Since isImmutable() is virtual, this could break the copy api.
Note that this actually occurs in the Scala serializers provided by Twitter's Chill (Traversable.scala) and causes lot's of KryoException to be thrown in Apache Flink + Scala usage (one could argue the Twitter serializer implementations are to blame.. or chaning member isImmutable() to be final would be a preferred option, but that would break API compatibility)