Refactor test dependencies #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunommc
reviewed
Jun 15, 2023
| gem "standard" | ||
| gem "appraisal" | ||
| gem "sidekiq", "~> 7.0" |
There was a problem hiding this comment.
I'm not sure I like this, because Sidekiq is now too tangled with acts_as_tenant. In fact, the sidekiq integration, DelayedJob or others, should be separate gems that depend on this one
IMO sidekiq doesn't belong in the Gemfile and should be in it's own appraisal
There was a problem hiding this comment.
This is simply for testing and there is no actual dependency on Sidekiq.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default Sidekiq version to 7 for tests and adds a specific appraisal for Sidekiq 6 since it needs to continue to be tested for backwards compatibility.