Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return instructions to correctly playwright install if browser binaries unavailable #358

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ErikBjare
Copy link
Owner

@ErikBjare ErikBjare commented Dec 20, 2024

Depends on #357, needs rebase.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c49c3c4 in 1 minute and 2 seconds

More details
  • Looked at 249 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. gptme/tools/_browser_thread.py:56
  • Draft comment:
    Ensure that the suggested command pipx run playwright=={pw_version} install chromium-headless-shell is correct and applicable for all users. The original command was pipx run playwright==$PW_VERSION install chromium. Verify if the change is intentional and correct.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. gptme/tools/_browser_thread.py:44
  • Draft comment:
    Changing the log level from info to debug for 'Browser thread started' might reduce its visibility in production environments. Ensure this change aligns with the logging strategy.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the logging level from info to debug for the message 'Browser thread started'. This might affect the visibility of this log message in production environments where the log level is set to info. It's important to ensure that this change is intentional and aligns with the logging strategy.
3. gptme/tools/_browser_thread.py:108
  • Draft comment:
    Consider whether the 'Browser operation completed' log statement should be at the debug level instead of info to avoid verbosity in production environments.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR introduces a new logging statement 'Browser operation completed' in the execute method. This log statement is at the info level, which might be too verbose for some production environments. Consider whether this should be at the debug level instead.

Workflow ID: wflow_7N57VEwxJXpwTvXo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

…t==version install ...` if browser binaries not available
@ErikBjare ErikBjare force-pushed the dev/better-browser-tool branch from c49c3c4 to 594c9a8 Compare December 20, 2024 12:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.12%. Comparing base (ef424be) to head (594c9a8).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
gptme/tools/_browser_thread.py 29.41% 12 Missing ⚠️
gptme/tools/browser.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   71.23%   71.12%   -0.12%     
==========================================
  Files          68       68              
  Lines        5271     5289      +18     
==========================================
+ Hits         3755     3762       +7     
- Misses       1516     1527      +11     
Flag Coverage Δ
anthropic/claude-3-haiku-20240307 69.38% <39.13%> (-0.11%) ⬇️
openai/gpt-4o-mini 67.95% <39.13%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare merged commit ebf5675 into master Dec 20, 2024
7 checks passed
@ErikBjare ErikBjare changed the title fix: return error with instructions to correctly pipx run playwright==version install ... if browser binaries not available fix: return instructions to correctly playwright install if browser binaries unavailable Dec 20, 2024
@ErikBjare ErikBjare changed the title fix: return instructions to correctly playwright install if browser binaries unavailable fix: return instructions to correctly playwright install if browser binaries unavailable Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants