-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: moved more core files to util module #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 113d2c1 in 11 seconds
More details
- Looked at
131
lines of code in7
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. gptme/chat.py:10
- Draft comment:
Remove the unused import statement foruse_fresh_context
since it has been moved to theutil
module. - Reason this comment was not posted:
Confidence changes required:50%
The import statement foruse_fresh_context
has been moved to theutil
module, but the import statement ingptme/chat.py
was not removed. This is a minor issue but should be corrected for consistency and to avoid confusion.
Workflow ID: wflow_NJzAYJxMY6gFdMfC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
113d2c1
to
8ad8f59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 8ad8f59 in 24 seconds
More details
- Looked at
169
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. gptme/util/export.py:2
- Draft comment:
The importjson
is unused and can be removed to clean up the code. This is also applicable to other files where unused imports are present. - Reason this comment was not posted:
Confidence changes required:50%
The import statements in the files have been updated to reflect the new module structure. However, there are some unused imports that should be removed to clean up the code.
2. gptme/util/interrupt.py:5
- Draft comment:
The importos
is unused and can be removed to clean up the code. This is also applicable to other files where unused imports are present. - Reason this comment was not posted:
Confidence changes required:50%
The import statements in the files have been updated to reflect the new module structure. However, there are some unused imports that should be removed to clean up the code.
3. gptme/util/reduce.py:8
- Draft comment:
The importlogging
is unused and can be removed to clean up the code. This is also applicable to other files where unused imports are present. - Reason this comment was not posted:
Confidence changes required:50%
The import statements in the files have been updated to reflect the new module structure. However, there are some unused imports that should be removed to clean up the code.
Workflow ID: wflow_8gSH8j9TMi4Egx7G
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
8ad8f59
to
2912086
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 2912086 in 33 seconds
More details
- Looked at
212
lines of code in11
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. tests/test_context.py:5
- Draft comment:
Update import to reflect new module structure.
from gptme.util.context import append_file_content, file_to_display_path, gather_fresh_context, get_mentioned_files
- Reason this comment was not posted:
Comment looked like it was already resolved.
2. tests/test_reduce.py:4
- Draft comment:
Update import to reflect new module structure.
from gptme.util.reduce import reduce_log, truncate_msg
- Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_jLrnKaIZ4T0jNyb0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 73.96% 73.96%
=======================================
Files 68 68
Lines 4948 4948
=======================================
Hits 3660 3660
Misses 1288 1288
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Important
Refactor by moving
context.py
,export.py
, andreduce.py
toutil
module and updating import paths in various files.context.py
,export.py
, andreduce.py
toutil
module.chat.py
,commands.py
, andlogmanager.py
to reflect new locations.use_fresh_context
inchat.py
andlogmanager.py
.export_chat_to_html
incommands.py
.limit_log
andreduce_log
inlogmanager.py
.reduce_log
andtruncate_msg
intest_reduce.py
.This description was created by for 2912086. It will automatically update as commits are pushed.