fix: correct Linux distro version in systeminfo prompt #239
Conversation
|
Closes #238 |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to f57e55a in 56 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_W5IyvzV3QkjJzNxM
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
gptme/prompts.py
Outdated
| @@ -247,6 +247,18 @@ def get_system_distro() -> str: | |||
| return "Linux" | |||
|
|
|||
|
|
|||
| def get_system_distro_version() -> str: | |||
| """Get the system distribution version.""" | |||
| regex = re.compile(r"^BUILD_ID=\"?([^\"]+)\"?") | |||
There was a problem hiding this comment.
The regex pattern should match VERSION_ID instead of BUILD_ID to correctly extract the system distribution version from /etc/os-release.
| regex = re.compile(r"^BUILD_ID=\"?([^\"]+)\"?") | |
| regex = re.compile(r"^VERSION_ID=\"?([^\"]+)\"?") |
There was a problem hiding this comment.
On arch it's BUILD_ID. But even co-pilot suggested the same thing. Let me check on fedora.
gptme/prompts.py
Outdated
| @@ -247,6 +247,18 @@ def get_system_distro() -> str: | |||
| return "Linux" | |||
|
|
|||
|
|
|||
| def get_system_distro_version() -> str: | |||
There was a problem hiding this comment.
I would merge this with get_system_distro and make it return a tuple[str, str]
|
Just learned about |
ErikBjare
changed the title
Important
Corrects Linux OS version retrieval in
prompt_systeminfo()by usingget_system_distro_version()instead ofplatform.uname().release.prompt_systeminfo()by replacingplatform.uname().releasewithget_system_distro_version().get_system_distro_version()to extract the Linux distribution version from/etc/os-releaseusing regex.This description was created by
for f57e55a. It will automatically update as commits are pushed.