[Ellipsis] feat: add system information prompts and minor text adjustments #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
❌ 9 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
|
@ellipsis-bot move the regex compilation out of the function to the global scope |
|
Could you specify which regex compilation you're referring to? This will help ensure the correct change is made. |
|
The regex compilation in the last commit you made @ellipsis-dev |
0xbrayo
approved these changes
Oct 26, 2024
|
@ellipsis-dev review |
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 56bd22f in 17 seconds
More details
- Looked at
84lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_0IQpac7hjYacpGia
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
Merged already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses review comments left by @brayo-pip on PR #171: feat: add platform info to the system prompt
Summary:
Add system information prompts in
prompts.pyand make minor text adjustments.Key points:
prompt_systeminfo()inprompts.pyto generate system information prompts for Linux, Windows, and macOS.prompt_systeminfo()intoprompt_full()inprompts.py.prompt_gptme()inprompts.py(removed comma).tools/shell.pyrelated to macOS platform check.You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Something look wrong? If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.
Generated with ❤️ by ellipsis.dev
Important
Add system information prompts in
prompts.pyand make minor text adjustments in prompt and shell files.prompt_systeminfo()inprompts.pyto generate system information prompts for Linux, Windows, and macOS.prompt_systeminfo()intoprompt_full()inprompts.py.prompt_gptme()inprompts.py(removed comma).tools/shell.pyrelated to macOS platform check.This description was created by
for 56bd22f. It will automatically update as commits are pushed.