Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEM format support #303

Merged
merged 12 commits into from
Sep 30, 2022
Merged

Conversation

valmiranogueira
Copy link
Contributor

@valmiranogueira valmiranogueira commented May 4, 2022

Closes #300

Introducing configuration for certificates in PEM format for CQL client and Tomcat server.

@valmiranogueira valmiranogueira changed the title PEMformat support PEM format support May 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #303 (ed65728) into master (fe9348d) will decrease coverage by 0.20%.
The diff coverage is 30.55%.

@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
- Coverage     75.60%   75.39%   -0.21%     
- Complexity     1190     1196       +6     
============================================
  Files           128      128              
  Lines          5164     5190      +26     
  Branches        520      527       +7     
============================================
+ Hits           3904     3913       +9     
- Misses         1106     1123      +17     
  Partials        154      154              
Impacted Files Coverage Δ
...ronos/application/ReloadingCertificateHandler.java 1.33% <0.00%> (-0.28%) ⬇️
...sandra/ecchronos/application/config/TLSConfig.java 80.00% <73.33%> (-2.70%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@masokol masokol self-requested a review May 5, 2022 06:44
Copy link
Contributor

@masokol masokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGES.md file as well.

Copy link
Contributor

@masokol masokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@itskarlsson
Copy link
Collaborator

I saw that this feature is supported in the newly released Springboot 2.7. Would be better if we could solve this by stepping the version instead.

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#web-server-ssl-configuration-using-pem-encoded-certificates

@itskarlsson itskarlsson merged commit aff281d into Ericsson:master Sep 30, 2022
@itskarlsson
Copy link
Collaborator

Thank you for your contribution

masokol added a commit to masokol/ecchronos that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support certificates in PEM format
4 participants