Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone daily update to 23:00 #5

Merged
merged 1 commit into from
May 12, 2021
Merged

Postpone daily update to 23:00 #5

merged 1 commit into from
May 12, 2021

Conversation

jbelien
Copy link
Member

@jbelien jbelien commented May 12, 2021

I don't really have an issue with a daily update but please postpone that daily update to the end of the day.

In issue EqualStreetNames/equalstreetnames#173, we noticed that if 2 updates are running at the same time, the push to main repository will fail for one of the update (see EqualStreetNames/equalstreetnames#173 (comment)).

To avoid that, the solution for now is to setup a clear calendar of updates so there is never 2 updates at the same time (see EqualStreetNames/equalstreetnames#173 (comment)).
The calendar starts at 01:00AM so you will need to postpone your update to later so your decision to update daily doesn't risk to block the merge of another city.

Postpone daily update to 23:00
@jbelien jbelien added the bug Something isn't working label May 12, 2021
@habi
Copy link
Collaborator

habi commented May 12, 2021

I thought that 04:00 is well into the night and not interfering with other updates.
I'm just now learning the cron syntax and would also be happy with an update every other day if that helps!

@habi habi merged commit 31cf7c8 into master May 12, 2021
@jbelien jbelien deleted the jbelien-patch-1 branch May 12, 2021 09:26
@jbelien
Copy link
Member Author

jbelien commented Jun 12, 2021

Hello @habi ,

Since there is no major updates anymore for Bern, can we go back to a weekly update ?
Daily update makes a lot of unnecessary commits in the main repository.

@habi
Copy link
Collaborator

habi commented Jun 12, 2021

Of course!
As I see it, we're (thanks to @chatelao) 'feature-complete'.
What's the best time?
The I can set up the Cron job correctly, at the moment I'm on my mobile...

@jbelien
Copy link
Member Author

jbelien commented Jun 12, 2021

As I see it, we're (thanks to @chatelao) 'feature-complete'.

Awesome! GREAT job! 🤩

What's the best time?

Every Friday at 01:00 : 0 1 * * 5

@habi
Copy link
Collaborator

habi commented Jun 14, 2021

Updated in c77d1bb

@chatelao
Copy link
Collaborator

Hi @habi and @jbelien totally fine for me - I've added the manual trigger anyway to the workflows, so if there is an urgent need for rebuilding any of you can trigger it.

@jbelien - Maybe you want to add this feature to the default template, so "hot" projects will not need the highspeed automatic updates.

image

@jbelien
Copy link
Member Author

jbelien commented Jun 14, 2021

@jbelien - Maybe you want to add this feature to the default template, so "hot" projects will not need the highspeed automatic updates.

I indeed did that for the most recents cities :)
Thanks a lot @chatelao !

@chatelao
Copy link
Collaborator

@jbelien you are more than welcome for your great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants