This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Bump Node.js to latest LTS #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StomyPX
changed the title
Belchy06
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
v16 end of life is on the 11th of September, see more information here:
https://nodejs.org/en/blog/announcements/nodejs16-eol
We need to update the version we fetch in the platform scripts.
Solution
I've changed the platform scripts to download the current LTS version instead: 18.17.0
Documentation
If you added a new feature or changed an existing feature please add some documentation here.
Or better yet, link to the relevant
/Docsupdate in your PR.Test Plan and Compatibility
I've run setup for Matchmaker, Signalling Server, and SFU in a freshened-up repo then fired up a packaged UE5.2.1 project and tried it out both with and without the SFU. Everything looks clear on Linux but someone needs to try it out on Windows as well.