This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Fix: Firefox console errors TypeError: this.preferredCodec.split is not a function
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belchy06
added
auto-backport
auto-backport-to-UE5.2
auto-backport-to-UE5.3
awaiting-approval
bug
lukehb
reviewed
Jul 18, 2023
|
Dropdown is disabled and displays 'Chrome Only'. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This was referenced Jul 18, 2023
Belchy06
added a commit
that referenced
this pull request
Jul 18, 2023
…not a function` (#310) (#312) * Fix select codec on Firefox * Restore indentation in cirrus (cherry picked from commit 503b565) Co-authored-by: William Belcher <[email protected]>
Belchy06
added a commit
that referenced
this pull request
Jul 18, 2023
…not a function` (#310) (#313) * Fix select codec on Firefox * Restore indentation in cirrus (cherry picked from commit 503b565) Co-authored-by: William Belcher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Addresses #309
Solution
As of 06/2023, Firefox has added
RTCRtpReceiver.getCapabilities, but hasn't added the ability to set codec preferences withtransceiver.setCodecPreferences. By simply checking if this method exists on a transceiver we can know if we are using Firefox or Chrome.