Added ByteItems support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustc-zzzz
reviewed
Feb 16, 2019
| @@ -61,7 +63,10 @@ | |||
| * @author ustc_zzzz | |||
| */ | |||
| @Plugin(name = "VirtualChest", id = VirtualChestPlugin.PLUGIN_ID, | |||
| dependencies = {@Dependency(id = "spongeapi"), @Dependency(id = "placeholderapi", version = "[4.0,)")}, | |||
There was a problem hiding this comment.
Do not remove the dependency of SpongeAPI. A new dependency with an API version will be added when the plugin is built and mcmod.info is generated if the dependency is not explicitly declared. VC is supposed to support both API 5 and API 7 and the version number of SpongeAPI is not expected in the dependency list.
| } | ||
| dependencies { | ||
| classpath 'net.minecrell:VanillaGradle:2.0.3_1' | ||
| classpath 'com.github.jengelman.gradle.plugins:shadow:1.2.4' | ||
| classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.7' | ||
| classpath 'net.minecraftforge.gradle:ForgeGradle:2.3-SNAPSHOT' | ||
| classpath 'org.javalite:activejdbc-gradle-plugin:1.4.13-SNAPSHOT' |
There was a problem hiding this comment.
Just change the version number to 2.2 instead of removing it simply since VC needs active jdbc instrumentation. Please refer to this.
|
Done. |
ustc-zzzz
added a commit
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #81 this adds support for ByteItems. To get this project even to compile, I had to apply the same changes as done in #72.