Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] calendar week option #478

Merged
merged 2 commits into from
Aug 13, 2014

Conversation

csnauwaert
Copy link
Contributor

ability to show/hide week number on the left of the date widget.

Inspired from eternicode bootstrap datepicker: https://github.com/eternicode/bootstrap-datepicker/tree/release

preview:
calendarweeks

@nikoskalogridis
Copy link
Contributor

please change your PR with the following and resubmit:

  • Fix header on top of weekday names to appear correctly
  • Change the default value to false so that it does not affect existing usage of the component

@Eonasdan
Copy link
Owner

calendarWeeks also needs to go into the fn.defaults and the dataToOptions function.

This will finally add the feature request from #130

oops missed it

@nikoskalogridis
Copy link
Contributor

It's already added on $.fn.defaults it only needs to be added to dataToOptions function. Also if I might suggest a # on the column header for the weeks. Also to have a @gray-light css color styling to be placed on the .cw

@nikoskalogridis
Copy link
Contributor

implemented on version 4 beta branch as well

@csnauwaert
Copy link
Contributor Author

Thanks for your comments, I made the change in the PR.

@nikoskalogridis
Copy link
Contributor

You also need to update the colspan in contTemplate to the following:
<td colspan="' + (options.calendarWeeks ? '8' : '7') + '">
Other than that I think its ok :)

@csnauwaert
Copy link
Contributor Author

Done :)

@nikoskalogridis
Copy link
Contributor

good job! thanks for your efforts

nikoskalogridis added a commit that referenced this pull request Aug 13, 2014
@nikoskalogridis nikoskalogridis merged commit a7965f1 into Eonasdan:development Aug 13, 2014
@webdevilopers
Copy link

👍

Is this implemented in the current version already?

Should the docs be updated?
http://eonasdan.github.io/bootstrap-datetimepicker/

@Eonasdan
Copy link
Owner

@webdevilopers I don't think this is in the master branch. Looks like it's still in the Dev branch.

@webdevilopers
Copy link

Thanks @Eonasdan . Has the milestone been scheduled?
I would like to add the new version / option to the https://github.com/sonata-project/SonataCoreBundle .

@ghost ghost locked and limited conversation to collaborators Jun 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants