Fix selecting month or year from month or year views with a valid date #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the code in more detail, I have a feeling that this is the wrong approach. I'll submit another pull request, and you can see if you think that one is better. |
|
Ah... It seems that github has just used my new approach with this pull request. The picker.date should only be set when a span is clicked on if the current view mode is the same as the min view mode. Otherwise it exits early. |
Eonasdan
added a commit
that referenced
this pull request
Feb 21, 2014
Fix selecting month or year from month or year views with a valid date
Eonasdan
added a commit
that referenced
this pull request
Mar 3, 2014
## 3.0.0 ## **Breaking changes in this update! Pay attention!!** * Fix for #170, #179, #183: Changed event to `dp.-` options load as `data-date-OPTION` instead of `data-OPTION`. This should fix the double change event firing. * Fix for #192: `setDate` now fires `dp.change` * Fix for #182: Picker will **not** set the default date if the input field has a value * Fix for #169: Seconds doesn't get reset when changing the date (Thanks to PR #174) * Fix for #168 z-index fix for BS modal * Fix for #155 Picker properly displays the active year and month * Fix for #154 CSS update to fix the collapse jump * Fix for #150 and #75 `minViewMode` and `viewMode` work properly * Fix for #44 Finally! It's here!! Thanks to @ruiwei and his code on #210 picker will adjust the positioning of the widget. #### **Manually merged PR** * #178 When using `minuteStepping` the minute select grid will only show available steppings * #195, #197 Using the `data-OPTION` has been changed to `data-date-OPTION`. These options are expected to be on the `input-group` if you're using the `form-group` **or** the input field * #184 The option `sideBySide` change be used to display both the d and the timepicker side by side #### **Other Changes** * Changed picker width to 300px if using seconds and am/pm * Added option `useCurrent`, thanks to @ruiwei. When true, picker will set the value to the current date/time (respects picker's format) * Added option `showToday`, thanks to @ruiwei. When true, picker will display a small arrow to indicate today's date. * Changed `startDate` to `minDate` and `endDate` to `maxDate` to make it more clear what these options do.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #196.
The easiest approach seems to be to leave the change method early if the viewMode isn't the day view.