Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RouteItem and add test cases #95

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Update RouteItem and add test cases #95

merged 2 commits into from
Feb 4, 2024

Conversation

matthyk
Copy link
Contributor

@matthyk matthyk commented Jan 21, 2024

Currently the method property in RouteItem is typed as HTTPMethods but with fastify.route you can also add an array of routes. I updated the types accordingly and added test cases

Eomm
Eomm reviewed Feb 4, 2024
View reviewed changes
Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the conflicts? 🙏🏼

@matthyk
Copy link
Contributor Author

matthyk commented Feb 4, 2024

Done :)

@Eomm Eomm merged commit 1327c0c into Eomm:main Feb 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthyk @Eomm