Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctests #2265

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix doctests #2265

merged 2 commits into from
Jan 17, 2025

Conversation

giordano
Copy link
Member

The filter already attempted to address the issue, but the syntax was incorrect
with the result that no substitution was applied.

Also, remove messing with LOAD_PATH and use sources section in docs project.

The filter already attempted to address the issue, but the syntax was incorrect
with the result that no substitution was applied.

Also, remove messing with `LOAD_PATH` and use `sources` section in docs project.
Comment on lines -1 to -3
pushfirst!(LOAD_PATH, joinpath(@__DIR__, "..")) # add Enzyme to environment stack
pushfirst!(LOAD_PATH, joinpath(@__DIR__, "..", "lib")) # add EnzymeCore to environment stack

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say how much frustration these two lines caused me, I was getting all the time, on different machines, absurd errors about LLVM or StaticArrays not being installed, while they were clearly in my environment. This drove me crazy!

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (037dfed) to head (006c822).
Report is 334 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2265      +/-   ##
==========================================
+ Coverage   67.50%   75.36%   +7.85%     
==========================================
  Files          31       56      +25     
  Lines       12668    16734    +4066     
==========================================
+ Hits         8552    12612    +4060     
- Misses       4116     4122       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Member Author

Documentation building is finally working again. Note that documentation hasn't been built in over a month since v0.13.20.

@wsmoses wsmoses requested a review from vchuravy January 17, 2025 02:59
Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[compat]
Documenter = "1"
Literate = "2"

[sources]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in in 1.11?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vchuravy vchuravy merged commit 3210e76 into EnzymeAD:main Jan 17, 2025
22 of 28 checks passed
@giordano giordano deleted the mg/fix-doctests branch January 17, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants