IfOp

[Pangoraw]

• region inlining if predicate is known
• transform to select for values which are not defined in inner regions
• forward
• reverse

I don't think the reverse could be used as is in a XLA pipeline since Enzyme is not yet able to remove all enzyme ops (which I think it technically could if there is no loop?).

[wsmoses]

lgtm [though also we'll need to figure out a good interface for the push/pop removal]

[Pangoraw]

though also we'll need to figure out a good interface for the push/pop removal

Yes. I also took a look at BatchOpInterface for IfOp and in its current state the interface only allows to return a single operation so we could not really unroll the batching like we discussed. So maybe BatchOpInterface has to be modified to provide a IRBuilder to createBatch and implementers do the result mapping themselves.

[wsmoses]

though also we'll need to figure out a good interface for the push/pop removal

Yes. I also took a look at BatchOpInterface for IfOp and in its current state the interface only allows to return a single operation so we could not really unroll the batching like we discussed. So maybe BatchOpInterface has to be modified to provide a IRBuilder to createBatch and implementers do the result mapping themselves.

Yeah I think so, as is it assumed a single op would suffice for batching