Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create subset for Austrailian and New Zealand soil semantics #1368

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

pbuttigieg
Copy link
Member

Closes #1366

@pbuttigieg pbuttigieg linked an issue Aug 18, 2022 that may be closed by this pull request
@pbuttigieg pbuttigieg self-assigned this Aug 18, 2022
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend following the existing naming conventions and using hyphen-separated lower case terms

I prefer acronyms to be spelled out, but I appreciate the spelled out name is quite long

I appreciate there is a precedent for the camelcase https://github.com/ANZSoilData/ANZSoilML so if it's important to mirror the source then ANZSoil is fine

@pbuttigieg
Copy link
Member Author

pbuttigieg commented Aug 18, 2022

Yes, we have an unruly mix. I want to retain the envo prefix so there's an indication that this is an adaptation of ANZSoil based on ENVO semantic approaches.

Otherwise some would mistake this for an official distribution from that authority.

Yes, it's in the full IRI, but not in the titles of the distributed files

@dr-shorthair
Copy link

envoANZSoil is OK by me

@pbuttigieg
Copy link
Member Author

pbuttigieg commented Aug 18, 2022

I've gotten informal approvals in the editors' Slack. I'll wait for at least one here.

@dr-shorthair
Copy link

Thx - Slack not normally open on my desktop - I'll go take a look.

@pbuttigieg pbuttigieg merged commit 1281944 into master Aug 19, 2022
@pbuttigieg pbuttigieg deleted the issue-1366 branch August 19, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANZSoil subset
3 participants