Issue 1182: ro_import does not include domain #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01000902] the axiom is already inherited from atmospheric lightning [ENVO_01000898]
…NVO_01000899] add annotaton QCR: 'has participant' min 2 cloud
…VO_01000900] add axiom annotation QCR: 'has participant' max 1 cloud
…n environmental zone of processual equilibrium [ENVO_01001353] add axiom annotation QCR: 'contains process' min 2 'environmental system process'
…ween astronomical bodies [ENVO_01001066] add axiom annotation QCR: 'has participant' min 2 'astronomical body'
…ctonic movement [ENVO_01001094] add axiom annotation QCR: 'has participant' min 2 'tectonic plate'
…tonic movement [ENVO_01001095] add axiom annotation QCR: 'has participant' min 2 'tectonic plate'
…ill sphere [ENVO_01001228] add axiom annotation QCR: 'process has causal agent' max 1 'astronomical body'
…rthquake [ENVO_01001778] add axiom annotation QCR: 'has participant' min 2 'tectonic plate'
…tonic movement [ENVO_01001096] add axiom annotation QCR: 'has participant' min 2 'tectonic plate'
…00062] add axiom annotation QCR: 'location of' min 1 building
…rthquake [ENVO_01001779] add axiom annotation QCR: 'has participant' max 1 'tectonic plate'
…nsfer process [ENVO_01001842] add axiom annotation QCR: 'has participant' min 2 'material entity'
changed ro-base_import to ro_import added `validate-dl-profile` target
|
@cmungall I've reverted the makefile to use I added a I see you made a |
cmungall
reviewed
Oct 13, 2021
cmungall
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1182
QCRs have been replaced with
somequalifier. When needed, a structured axiom annotation has been added to capture the cardinality constraint.To test, an
ro_testtarget has been added to the makefile. However, I could not get reasoning to complete. My machine ran out of memory, even when the robot memory was set to 28G. Unless we can find a beefier machine to test with, I think we need to rebuild the ro import (which has fewer terms than full ro).A
dl-profile-errors.txttarget was also added for creating (for now) a local file with any DL violations. All the QCR errors have been addressed. However, there are some other issues with foodon terms that haven't been declared. Let's deal with these in a separate PR.