Add stricter check to prevent logical equivalents #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
changed the title
wdduncan
reviewed
Aug 25, 2021
| @@ -158,7 +158,7 @@ $(ONT)-base.owl: $(SRC) $(OTHER_SRC) | |||
| # Full: The full artefacts with imports merged, reasoned | |||
| $(ONT)-full.owl: $(SRC) $(OTHER_SRC) | |||
| $(ROBOT) merge --input $< \ | |||
| reason --reasoner ELK --equivalent-classes-allowed all --exclude-tautologies structural \ | |||
| reason --reasoner ELK --equivalent-classes-allowed none --exclude-tautologies structural \ | |||
There was a problem hiding this comment.
Do you want to use --equivalent-classes-allowed asserted-only?
There was a problem hiding this comment.
This is for you to decide! I mostly prefer to strictly forbid equivalents, but if it's ENVOs policy to allow asserted ones go ahead!! Thanks for looking!
There was a problem hiding this comment.
Thanks @matentzn ... the decision is not mine alone to make :)
What do you think @cmungall @pbuttigieg ?
There was a problem hiding this comment.
We should absolutely forbid all equivalents between named classes, whether asserted or inferred. We never intend to do this, and if the reasoner finds this it is always revealing an error. If we had implemented this sooner we would have prevented a lot of pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1196