Added two new devices. Ambisonic Sample Scrubber and E4L Midi Controlled B Format Sampler #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E4L Midi Controlled B Format Sampler is Mark Slee's sampler with simple midi functionality added, as well as speed, pitch (with timestretch), and sample start controls. Ambisonic Sample Scrubber is another B-format/Ambix sampler built with ~groove. This one has speed, pitch, and sample start/length controls, a filter section with dedicated envelope, an amp envelope, and switchable midi control over the different parameters. Joe Stratton @bothelbows
|
Awesome work! I think there's some issue with the Ambisonic Sample Scrubber. The CPU is low until I click Midi Note Control to "pitch" and then everything goes haywire, and clicking "off" doesn't change anything. So I would look into what's happening in that subroutine that might trigger a feedback loop or something that would spike CPU... |
|
Interesting. I haven’t had that issue myself but I’ll give it a closer
look.
Thanks
Joe
On Sun, May 16, 2021 at 1:35 AM Roddy Lindsay ***@***.***> wrote:
Awesome work! I think there's some issue with the Ambisonic Sample
Scrubber. The CPU is low until I click Midi Note Control to "pitch" and
then everything goes haywire, and clicking "off" doesn't change anything.
So I would look into what's happening in that subroutine that might trigger
a feedback loop or something that would spike CPU...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOHJABP5VQS56UN52JFY7WTTN5KQRANCNFSM446FNKFQ>
.
--
*Joe Stratton*
*www.bothelbows.com <http://www.bothelbows.com>720.891.9521*
|
|
Big thanks for these Joe - I will try to do a proper full review of these sometime these week. I'd also like to consider making your Midi Controlled sampler the "standard" one and deprecating the existing B-Format Sampler. My long-term hope was always to make that sampler much more MIDI-oriented and similar to Ableton's native Simpler/Sampler. So after I've haven a look I also may suggest renaming this one to "E4L Simpler" or "E4L Sampler" to imply that this is the "default" sampler people should be using, a la Ableton. Will keep you posted after I've had a chance to dive into the code. |
|
Sounds good, Mark, thanks.
I'll be trying to rework the Ambisonic Sample Scrubber this week as well.
As Roddy said, there's some issue overdriving the CPU. Seems like it has
something to do with timestretch but I have yet to find a fix.
Joe
…On Sun, May 16, 2021 at 12:06 PM Mark Slee ***@***.***> wrote:
Big thanks for these Joe - I will try to do a proper full review of these
sometime these week. I'd also like to consider making your Midi Controlled
sampler the "standard" one and deprecating the existing B-Format Sampler.
My long-term hope was always to make that sampler much more MIDI-oriented
and similar to Ableton's native Simpler/Sampler. So after I've haven a look
I also may suggest renaming this one to "E4L Simpler" or "E4L Sampler" to
imply that this is the "default" sampler people should be using, a la
Ableton.
Will keep you posted after I've had a chance to dive into the code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOHJABOZY2I7WVPSWKHNYYLTN7UPBANCNFSM446FNKFQ>
.
--
*Joe Stratton*
*www.bothelbows.com <http://www.bothelbows.com>720.891.9521*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E4L Midi Controlled B Format Sampler is Mark Slee's sampler with simple midi functionality added, as well as speed, pitch (with timestretch), and sample start controls.
Ambisonic Sample Scrubber is another B-format/Ambix sample player built with ~groove. This one has speed, pitch, and sample start/length controls, a filter section with dedicated envelope, an amp envelope, and switchable midi control over the different parameters. It's also set up with viewable controls for the Push 2.
Joe Stratton @bothelbows