Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against Rails 7.2 #33

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Run CI against Rails 7.2 #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b3c20d
Run CI against Rails 7.2
ohbarye Aug 18, 2024
a9db020
Add /gemfiles/vendor/ to .gitignore
ohbarye Aug 18, 2024
e4587c0
Rails 6.1 or above should use rspec-rails 6.x to comply its policy
ohbarye Aug 18, 2024
be43c94
Rails 8.0 require sqlite3 2.0 or above
ohbarye Aug 18, 2024
65d467a
Add Ruby 3.3 x Rails 7.2 to test matrix
ohbarye Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ jobs:
- ruby: '3.2'
activerecord: '7.1'
gemfile: 'activerecord_7_1.gemfile'
- ruby: '3.1'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rails 7.2 supports Ruby 3.1 as a minimum version.

https://guides.rubyonrails.org/7_2_release_notes.html

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that it is enough to test against latest stable version of Ruby

activerecord: '7.2'
gemfile: 'activerecord_7_2.gemfile'
- ruby: '3.2'
activerecord: '7.2'
gemfile: 'activerecord_7_2.gemfile'
- ruby: '3.3'
activerecord: '7.2'
gemfile: 'activerecord_7_2.gemfile'
- ruby: '3.3'
activerecord: 'HEAD'
gemfile: 'activerecord_master.gemfile'
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
/spec/reports/
/tmp/
/gemfiles/*.lock
/gemfiles/vendor/

# rspec failure tracking
.rspec_status
6 changes: 6 additions & 0 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ appraise "activerecord-7-1" do
gem "rspec-rails", "~> 5.0"
end

appraise "activerecord-7-2" do
gem "activerecord", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
end

appraise "activerecord-master" do
git "https://github.com/rails/rails.git" do
gem "rails"
Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
after_commit_everywhere (1.3.1)
after_commit_everywhere (1.4.0)
activerecord (>= 4.2)
activesupport

Expand Down
2 changes: 1 addition & 1 deletion gemfiles/activerecord_6_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activerecord", "~> 6.1.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 4.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activerecord", "~> 7.0.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

gem "activerecord", "~> 7.1.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
9 changes: 9 additions & 0 deletions gemfiles/activerecord_7_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "activerecord", "~> 7.2.0"
gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"
4 changes: 2 additions & 2 deletions gemfiles/activerecord_master.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ git "https://github.com/rails/rails.git" do
gem "activerecord"
end

gem "sqlite3", "~> 1.4"
gem "rspec-rails", "~> 5.0"
gem "sqlite3", "~> 2.0"
gem "rspec-rails", "~> 6.0"

gemspec path: "../"