Allow variance of other versions, account for dill fix #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlockwood
force-pushed
the
allow-other-version-variance
branch
from
9d6e2dd to
3cb6649
Compare
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=========================================
- Coverage 99.9% 99.9% -0.01%
=========================================
Files 12 12
Lines 2151 2149 -2
=========================================
- Hits 2149 2147 -2
Misses 2 2
Continue to review full report at Codecov.
|
|
The coverage failure seems to be a false positive from reducing number of lines so I'm merging despite that. Thanks for sorting more flexible versions out! |
|
Thanks @EntilZha! Do you have any estimate on when these changes might be released? |
|
I'll see if I can get travis ci setup for push-button releases today or tomorrow at which point it would be easy to release |
drachpy
pushed a commit
to drachpy/PyFunctional
that referenced
this pull request
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68 (unless I've misunderstood!)
Follows on from #116.
@EntilZha, please see what you think.