Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDE: improvements and fixes for DOCS-1147 #6342

Merged
merged 6 commits into from
Dec 12, 2024
Merged

TDE: improvements and fixes for DOCS-1147 #6342

merged 6 commits into from
Dec 12, 2024

Conversation

gvasquezvargas
Copy link
Contributor

What Changed?

Some High priority fixes and iprovements for https://enterprisedb.atlassian.net/browse/DOCS-1147

@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Dec 10, 2024
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner December 10, 2024 23:05
@gvasquezvargas gvasquezvargas marked this pull request as draft December 10, 2024 23:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-6342--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-6342-transparent_data_encryption-streamlining_docs December 10, 2024 23:15 Inactive
@github-actions github-actions bot temporarily deployed to pr-6342-transparent_data_encryption-streamlining_docs December 11, 2024 16:00 Inactive
@gvasquezvargas gvasquezvargas marked this pull request as ready for review December 12, 2024 17:05
@gvasquezvargas gvasquezvargas force-pushed the transparent_data_encryption/streamlining_docs branch from 2badc9a to 8a423ca Compare December 12, 2024 17:05
@github-actions github-actions bot temporarily deployed to pr-6342-transparent_data_encryption-streamlining_docs December 12, 2024 17:15 Inactive
@github-actions github-actions bot temporarily deployed to pr-6342-transparent_data_encryption-streamlining_docs December 12, 2024 17:27 Inactive
josh-heyer
josh-heyer requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@josh-heyer josh-heyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of blocks in this that could use manually wrapping (beyond the one you've already done).

Also two invocations of /usr/lib/edb-as/16/bin/pg_upgrade in enabling_tde_epas.mdx that could use the same treatment, and two more in postgres_to_extended.mdx.

product_docs/docs/tde/15/encrypted_files/wal_files.mdx Outdated Show resolved Hide resolved
product_docs/docs/tde/15/secure_key/index.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-6342-transparent_data_encryption-streamlining_docs December 12, 2024 17:49 Inactive
@gvasquezvargas gvasquezvargas force-pushed the transparent_data_encryption/streamlining_docs branch from 54149a9 to 4f48893 Compare December 12, 2024 17:49
josh-heyer
josh-heyer approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@josh-heyer josh-heyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gvasquezvargas gvasquezvargas merged commit fb53637 into develop Dec 12, 2024
3 checks passed
@gvasquezvargas gvasquezvargas deleted the transparent_data_encryption/streamlining_docs branch December 12, 2024 18:00
@gvasquezvargas gvasquezvargas mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeyshishkin-edb alexeyshishkin-edb alexeyshishkin-edb approved these changes

@josh-heyer josh-heyer josh-heyer approved these changes

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvasquezvargas @josh-heyer @alexeyshishkin-edb