-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added info about the Promote Status section of cluster status output #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EFM-Bobby
added
the
deploy
Add this label to a PR and it will automatically be deployed to netlify
label
Dec 2, 2024
EFM-Bobby
commented
Dec 2, 2024
The `Promote Status` section of the report is the result of a direct query from the node on which you are invoking the `cluster-status` command to each database in the cluster. The query also returns the transaction log location of each database. Because the queries to each database return at different times, the LSNs might not match even if streaming replication is working normally for the cluster. To get the latest view of replication, connect to the primary database, and execute SQL command `SELECT * FROM pg_stat_replication;`. | ||
The `Promote Status` section of the report includes information related to promotion in the cluster. The LSN information is used, along with the `Standby priority host list`, when choosing a standby to promote. If there is a mismatch in replay LSNs, Failover Manager will not allow a switchover (though the promotion of a standby is always allowed). | ||
|
||
The LSN information is the result of a direct query from the node on which you are invoking the `cluster-status` command to each database in the cluster. The query also returns the transaction log location of each database. Because the queries to each database return at different times, the LSNs might not match even if streaming replication is working normally for the cluster. To get the latest view of replication, connect to the primary database, and execute SQL command `SELECT * FROM pg_stat_replication;`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...is a result of a direct query..." text is unchanged except for being moved to a new paragraph.
github-actions
bot
temporarily deployed
to
pr-6317-efm-promote-status-explanation
December 2, 2024 16:11
Inactive
…output This leaves the existing info mostly alone, but adds an explanation of the Promote Status output and why it's there. Users sometimes think this is meant to check if replication is working, or want more information listed. The info that efm collects here is all related to whether or not a promotion would be safe (or a switchover allowed) and how a standby would be picked. It's not meant to be the place a user monitors replication. The existing text goes into detail a little about it, but this new text explains why this particular info is here.
gvasquezvargas
force-pushed
the
efm/promote-status-explanation
branch
from
December 3, 2024 07:48
099ea60
to
99d4f4a
Compare
gvasquezvargas
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves the existing info mostly alone, but adds an explanation of the Promote Status output and why it's there. The info that efm collects here is all related to whether or not a promotion would be safe (or a switchover allowed) and how a standby would be picked. It's not meant to be the place a user monitors replication. The existing text goes into detail a little about this, but the new text explains why this particular info is here if not meant to check replication.
What Changed?