Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about the Promote Status section of cluster status output #6317

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

EFM-Bobby
Copy link
Contributor

This leaves the existing info mostly alone, but adds an explanation of the Promote Status output and why it's there. The info that efm collects here is all related to whether or not a promotion would be safe (or a switchover allowed) and how a standby would be picked. It's not meant to be the place a user monitors replication. The existing text goes into detail a little about this, but the new text explains why this particular info is here if not meant to check replication.

What Changed?

@EFM-Bobby EFM-Bobby requested a review from a team as a code owner December 2, 2024 16:01
@EFM-Bobby EFM-Bobby added the deploy Add this label to a PR and it will automatically be deployed to netlify label Dec 2, 2024
The `Promote Status` section of the report is the result of a direct query from the node on which you are invoking the `cluster-status` command to each database in the cluster. The query also returns the transaction log location of each database. Because the queries to each database return at different times, the LSNs might not match even if streaming replication is working normally for the cluster. To get the latest view of replication, connect to the primary database, and execute SQL command `SELECT * FROM pg_stat_replication;`.
The `Promote Status` section of the report includes information related to promotion in the cluster. The LSN information is used, along with the `Standby priority host list`, when choosing a standby to promote. If there is a mismatch in replay LSNs, Failover Manager will not allow a switchover (though the promotion of a standby is always allowed).

The LSN information is the result of a direct query from the node on which you are invoking the `cluster-status` command to each database in the cluster. The query also returns the transaction log location of each database. Because the queries to each database return at different times, the LSNs might not match even if streaming replication is working normally for the cluster. To get the latest view of replication, connect to the primary database, and execute SQL command `SELECT * FROM pg_stat_replication;`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...is a result of a direct query..." text is unchanged except for being moved to a new paragraph.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

@github-actions github-actions bot temporarily deployed to pr-6317-efm-promote-status-explanation December 2, 2024 16:11 Inactive
…output

This leaves the existing info mostly alone, but adds an explanation of the Promote Status output and why it's there. Users sometimes think this is meant to check if replication is working, or want more information listed. The info that efm collects here is all related to whether or not a promotion would be safe (or a switchover allowed) and how a standby would be picked. It's not meant to be the place a user monitors replication. The existing text goes into detail a little about it, but this new text explains why this particular info is here.
Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gvasquezvargas gvasquezvargas merged commit 61fca9d into develop Dec 3, 2024
3 checks passed
@gvasquezvargas gvasquezvargas deleted the efm/promote-status-explanation branch December 3, 2024 09:00
@jpe442 jpe442 mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants