Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTK: added note on unquoted password for toolkit-properties #6258

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

gvasquezvargas
Copy link
Contributor

@gvasquezvargas gvasquezvargas commented Nov 19, 2024

What Changed?

https://enterprisedb.atlassian.net/browse/DOCS-1111
Originated from Slack convo, see Jira for more details.

@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Nov 19, 2024
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner November 19, 2024 14:05
Copy link
Contributor

github-actions bot commented Nov 19, 2024

@github-actions github-actions bot temporarily deployed to pr-6258-mtk-unquoted_pw November 19, 2024 14:15 Inactive
Copy link
Contributor

@mlewandowski-edb mlewandowski-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the confusion of the user and password properties in the defining URL sections.

@github-actions github-actions bot temporarily deployed to pr-6258-mtk-unquoted_pw November 20, 2024 09:19 Inactive
Copy link

@zahid75 zahid75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are in place, look good.

Copy link
Contributor

@mlewandowski-edb mlewandowski-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment suggesting a minor change.


- `TARGET_DB_PASSWORD` — Contains the password of the specified user.
Ensure this value is set in Cloud Service:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sslmode parameter is part of the connection URL for cloud service connections. I think this should be moved up to the text that describes the connection URL settings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I thought it was a Console configuration. Updated ✅

@gvasquezvargas gvasquezvargas merged commit b2f39a9 into develop Nov 21, 2024
3 checks passed
@gvasquezvargas gvasquezvargas deleted the mtk/unquoted_pw branch November 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants