Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs #6172

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs #6172

merged 9 commits into from
Nov 8, 2024

Conversation

jpe442
Copy link
Contributor

@jpe442 jpe442 commented Oct 21, 2024 •
edited by jira bot
Loading

Replaces instances of 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs to reflect the updated (and preferred) syntax option for 5.6.

DOCS-1055

@jpe442 jpe442 marked this pull request as ready for review October 21, 2024 17:04
@jpe442 jpe442 requested a review from a team as a code owner October 21, 2024 17:04
@jpe442 jpe442 added the deploy Add this label to a PR and it will automatically be deployed to netlify label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-6172--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-6172-docs-1055 October 21, 2024 17:18 Inactive
@jpe442 jpe442 requested a review from djw-m October 21, 2024 17:35
@djw-m djw-m changed the base branch from develop to DOCS-1076-documenting-pgd-5-6-1-5-next November 5, 2024 15:30
@djw-m
Copy link
Contributor

djw-m commented Nov 5, 2024

Need to remove the simple "alias: SYNCHRONOUS_COMMIT" from the top of the reference page and then in the details section do something like:

"SYNCHRONOUS COMMIT" in commit scope rules has an alias, "SYNCHRONOUS_COMMIT". The use of the space in the commit scope helps to distinguish it from Postgres's SYNCHRONOUS_COMMMIT.

@jpe442
Copy link
Contributor Author

jpe442 commented Nov 5, 2024

Need to remove the simple "alias: SYNCHRONOUS_COMMIT" from the top of the reference page and then in the details section do something like:

"SYNCHRONOUS COMMIT" in commit scope rules has an alias, "SYNCHRONOUS_COMMIT". The use of the space in the commit scope helps to distinguish it from Postgres's SYNCHRONOUS_COMMMIT.

got it

@github-actions github-actions bot temporarily deployed to pr-6172-docs-1055 November 5, 2024 18:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-6172-docs-1055 November 6, 2024 19:15 Inactive
@djw-m djw-m self-requested a review November 7, 2024 12:14
djw-m
djw-m approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djw-m and others added 3 commits November 7, 2024 12:31
@djw-m
Added bdr_config - reformatted node state table.
7331389 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m @jpe442
Known issues as of 30Oct update (#6195)
b8ae9ee 
* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>
@djw-m
Update known issues for BFILE
847cb70 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m djw-m force-pushed the DOCS-1076-documenting-pgd-5-6-1-5-next branch from dd4cf9f to 847cb70 Compare November 7, 2024 12:31
@github-actions github-actions bot temporarily deployed to pr-6172-docs-1055 November 7, 2024 22:02 Inactive
@djw-m djw-m force-pushed the DOCS-1076-documenting-pgd-5-6-1-5-next branch from 847cb70 to cef2909 Compare November 8, 2024 08:52
@github-actions github-actions bot temporarily deployed to pr-6172-docs-1055 November 8, 2024 20:43 Inactive
@jpe442 jpe442 merged commit afcd2f5 into DOCS-1076-documenting-pgd-5-6-1-5-next Nov 8, 2024
3 of 5 checks passed
@jpe442 jpe442 deleted the DOCS-1055 branch November 8, 2024 20:53
djw-m added a commit that referenced this pull request Nov 13, 2024
@jpe442 @djw-m
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
3197434 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
josh-heyer pushed a commit that referenced this pull request Nov 18, 2024
@jpe442 @djw-m @josh-heyer
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
e97b9e9 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
djw-m added a commit that referenced this pull request Nov 20, 2024
@jpe442 @djw-m
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
0fb1236 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
djw-m added a commit that referenced this pull request Nov 21, 2024
@jpe442 @djw-m
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
73b3a92 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
djw-m added a commit that referenced this pull request Nov 21, 2024
@jpe442 @djw-m
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
22615bc 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
djw-m added a commit that referenced this pull request Nov 25, 2024
@jpe442 @djw-m
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
f272b11 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
djw-m added a commit that referenced this pull request Nov 25, 2024
@jpe442 @djw-m
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
5fe8e25 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
gvasquezvargas pushed a commit that referenced this pull request Nov 28, 2024
@jpe442 @djw-m @gvasquezvargas
Replace 'SYNCHRONOUS_COMMIT' with 'SYNCHRONOUS COMMIT' in 5.6 docs (#…
d36c6c6 
…6172)

* Added bdr_config - reformatted node state table.

Signed-off-by: Dj Walker-Morgan <[email protected]>

* Known issues as of 30Oct update (#6195)

* Known issues as of 30Oct update

Signed-off-by: Dj Walker-Morgan <[email protected]>

* small changes.

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Josh Earlenbaugh <[email protected]>

* Update known issues for BFILE

Signed-off-by: Dj Walker-Morgan <[email protected]>

* replaced in commit-scope-rules.mdx

* Replaced in degrading.mdx.

* Replaced in synchronous commit page.

* Replaced in references.

* Resolving conflict

* Update product_docs/docs/pgd/5.6/commit-scopes/synchronous_commit.mdx

Co-authored-by: Dj Walker-Morgan <[email protected]>

---------

Signed-off-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw-m djw-m djw-m approved these changes

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpe442 @djw-m