Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: Mac uninstall #4743

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

drothery-edb
Copy link
Contributor

What Changed?

Changes related to #4719

@drothery-edb drothery-edb added the deploy Add this label to a PR and it will automatically be deployed to netlify label Aug 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

@github-actions github-actions bot temporarily deployed to pr-4743-docs-postgresql-mac-uninstall August 31, 2023 18:48 Inactive
@drothery-edb drothery-edb force-pushed the docs/postgresql/mac-uninstall branch from 776070f to 1b2e8b9 Compare August 31, 2023 18:49
@github-actions github-actions bot temporarily deployed to pr-4743-docs-postgresql-mac-uninstall August 31, 2023 19:00 Inactive
@@ -51,15 +52,21 @@ These instructions apply if you used EDB's interactive Mac installer to install

To uninstall PostgreSQL on a Mac system:

1. Assume the identity of an operating system superuser, and navigate into the folder where the uninstaller resides:
1. Assume the identity of an operating system superuser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still rather unsure about this step - if it's actually necessary, I would expect an example - AFAIK, this is somewhat more involved on macs than on most Linux distros.

We should try to get more info here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josh-heyer,
sudo /Library/PostgreSQL/13/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh

launches the uninstaller in GUI mode on Mac

Screenshot 2023-09-01 at 4 10 54 PM

Copy link
Contributor Author

@drothery-edb drothery-edb Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidhibhammar does that mean step 1 and 2 aren't necessary? I assume so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have combined both steps and written as one step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this also executes a shell script instead of trying to launch the app directly. Not sure what's in the script, but perhaps this is why @kiisodj was encountering issues. If the shell script is the recommended way of launching the uninstaller, let's update the docs ASAP!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidhibhammar can you confirm that the shell script is the recommended way of launching the uninstaller?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES , that's the right way to launch the uninstaller on MAC

sudo /Library/PostgreSQL/13/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh

@drothery-edb drothery-edb force-pushed the docs/postgresql/mac-uninstall branch from 02958f3 to e0fc648 Compare September 6, 2023 14:19
@github-actions github-actions bot temporarily deployed to pr-4743-docs-postgresql-mac-uninstall September 6, 2023 14:23 Inactive
1. Invoke the uninstaller:

`open uninstall-postgresql.app`
```
sudo /Library/PostgreSQL/<version>/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo /Library/PostgreSQL/<version>/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh
open /Library/PostgreSQL/<version>/uninstall-postgresql.app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the appropriate way to invoke the uninstaller. It blocks the ability for users to use a safe admin account on the mac.

sudo /Library/PostgreSQL/<version>/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh
```

Where `<version>` is the version of PostgreSQL you installed.

1. If prompted, provide a password that allows the uninstaller to make changes to your system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You will be prompted for a password. If your user has admin rights on macOS, enter your password. Otherwise, enter the user name and password of a user with admin rights.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded the wording to explain what is being prompted for.

1. Invoke the uninstaller:

`open uninstall-postgresql.app`
```
sudo /Library/PostgreSQL/<version>/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the appropriate way to invoke the uninstaller. It blocks the ability for users to use a safe admin account on the mac.

sudo /Library/PostgreSQL/<version>/uninstall-postgresql.app/Contents/MacOS/installbuilder.sh
```

Where `<version>` is the version of PostgreSQL you installed.

1. If prompted, provide a password that allows the uninstaller to make changes to your system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanded the wording to explain what is being prompted for.

@djw-m djw-m force-pushed the docs/postgresql/mac-uninstall branch from e0fc648 to 3317023 Compare September 8, 2023 11:18
@github-actions github-actions bot temporarily deployed to pr-4743-docs-postgresql-mac-uninstall September 8, 2023 11:22 Inactive
@github-actions github-actions bot temporarily deployed to pr-4743-docs-postgresql-mac-uninstall September 8, 2023 13:25 Inactive
@djw-m djw-m self-requested a review September 8, 2023 13:50
@djw-m djw-m force-pushed the docs/postgresql/mac-uninstall branch from 23bda5e to 4980cdb Compare September 8, 2023 13:52
@djw-m djw-m self-requested a review September 8, 2023 13:52
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drothery-edb drothery-edb merged commit e77e95f into develop Sep 8, 2023
1 check passed
@drothery-edb drothery-edb deleted the docs/postgresql/mac-uninstall branch September 8, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants