Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize local pdf building #1043

Closed
epbarger opened this issue Mar 8, 2021 · 0 comments · Fixed by #1047
Closed

Dockerize local pdf building #1043

epbarger opened this issue Mar 8, 2021 · 0 comments · Fixed by #1047

Comments

@epbarger
Copy link
Contributor

epbarger commented Mar 8, 2021

Goal

Replace yarn build-pdf /pdf/path with a new command that builds the pdf within a docker contianer. It needs to take in a path to a doc directory, and sync the resulting file back to the host filesystem (2-way volume?).

We want to avoid users needing to setup pandoc and wkhtmltopdf on their local machine.

Dependencies

  • python 3 >= 3.6
  • wkhtmltopdf 0.12.6 (latest version)
  • pandoc (latest version)

Example

yarn build-pdf-docker /product_docs/docs/epas/13/epas_inst_linux/ should spin up the container if needed, run python3 scripts/pdf/generate_pdf.py /product_docs/docs/epas/13/epas_inst_linux/, display the output of the script on the screen for debugging, and ultimately create the pdf at product_docs/docs/epas/13/epas_inst_linux/epas_v13_epas_inst_linux_documentation.pdf. The pdf should be available on the host filesystem.

gsong pushed a commit that referenced this issue Mar 9, 2021
gsong pushed a commit that referenced this issue Mar 9, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
Move `build-all-pdfs` to `build-all-pdfs-ci` for usage in CI.

Closes #1043
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
Move `build-all-pdfs` to `build-all-pdfs-ci` for usage in CI.

Closes #1043
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 10, 2021
Move `build-all-pdfs` to `build-all-pdfs-ci` for usage in CI.

Addresses #1043
gsong pushed a commit that referenced this issue Mar 10, 2021
gsong pushed a commit that referenced this issue Mar 11, 2021
gsong pushed a commit that referenced this issue Mar 11, 2021
Move `build-all-pdfs` to `build-all-pdfs-ci` for usage in CI.

Addresses #1043
gsong pushed a commit that referenced this issue Mar 11, 2021
gsong pushed a commit that referenced this issue Mar 11, 2021
No need to set up wkhtmltopdf for local environment

Addresses #1043
robert-stringer pushed a commit that referenced this issue Mar 18, 2021
robert-stringer pushed a commit that referenced this issue Mar 18, 2021
Move `build-all-pdfs` to `build-all-pdfs-ci` for usage in CI.

Addresses #1043
robert-stringer pushed a commit that referenced this issue Mar 18, 2021
No need to set up wkhtmltopdf for local environment

Addresses #1043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant